Use the client-id, instead of app-id

Author: a-maurice

.github/workflows/cpp-packaging.yml

@@ -887,8 +887,7 @@ jobs:
       uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
       id: generate-token
       with:
-        # we should migrate to client-id
-        app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
+        client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
         private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
         permission-actions: write
     - name: Use GitHub API to start workflow
@@ -956,8 +955,7 @@ jobs:
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
         id: generate-token
         with:
-          # we should migrate to client-id
-          app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
+          client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
           private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
           permission-actions: write
       - name: Retry failed tests

.github/workflows/integration_tests.yml

@@ -1526,8 +1526,7 @@ jobs:
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
         id: generate-token
         with:
-          # we should migrate to client-id
-          app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
+          client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
           private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
           permission-pull-requests: write
       - name: Update PR label and comment
@@ -1601,8 +1600,7 @@ jobs:
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
         id: generate-token
         with:
-          # we should migrate to client-id
-          app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
+          client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
           private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
           permission-actions: write
       - name: Retry failed tests

.github/workflows/retry-test-failures.yml

@@ -16,8 +16,7 @@ jobs:
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
         id: generate-token
         with:
-          # we should migrate to client-id
-          app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
+          client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
           private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
           permission-actions: write
 

.github/workflows/update-dependencies.yml

@@ -30,12 +30,13 @@ jobs:
     runs-on: macos-15
     steps:
       - name: Get token for firebase-workflow-trigger
-        uses: tibdex/github-app-token@v1
+        uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
         id: generate-token
         with:
-          # we should migrate to client-id
-          app_id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
-          private_key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
+          client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
+          private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
+          permission-contents: write
+          permission-pull-requests: write
 
       - name: Setup python
         uses: actions/setup-python@7f4fc3e22c37d6ff65e88745f38bd3157c663f7c # ratchet:actions/setup-python@v4

.github/workflows/update-feature-branches.yml

@@ -77,8 +77,7 @@ jobs:
         uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # ratchet:actions/create-github-app-token@v1
         id: generate-token
         with:
-          # we should migrate to client-id
-          app-id: ${{ secrets.WORKFLOW_TRIGGER_APP_ID }}
+          client-id: ${{ secrets.WORKFLOW_TRIGGER_CLIENT_ID }}
           private-key: ${{ secrets.WORKFLOW_TRIGGER_APP_PRIVATE_KEY }}
           permission-contents: write
           permission-pull-requests: write