Skip to content

Commit c5217ac

Browse files
committed
Pin build to windows 2022
The latest windows github runner windows 2026 comes with visual studio 18. Which need an updated version of Cmake (4.2+) to work. The generators concept introduced does not work with older version of cmake. Firestore still depend on Cmake 3.x feature so we cannot update Cmake While we wait for firestore updates pin windows to 2022 version .
1 parent 9ae22e9 commit c5217ac

5 files changed

Lines changed: 21 additions & 20 deletions

File tree

.github/workflows/android.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
python_version: ${{ fromJson(needs.prepare_matrix.outputs.matrix_python_version) }}
5353
exclude:
5454
# Do not attempt to use arm64 on Windows or Linux.
55-
- os: windows-latest
55+
- os: windows-2022
5656
architecture: arm64
5757
- os: ubuntu-22.04
5858
architecture: arm64

.github/workflows/cpp-packaging.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -320,17 +320,17 @@ jobs:
320320
strategy:
321321
fail-fast: false
322322
matrix:
323-
os: [windows-latest, ubuntu-22.04, macos-15]
323+
os: [windows-2022, ubuntu-22.04, macos-15]
324324
build_type: ["Release", "Debug"]
325325
architecture: ["x64", "x86", "arm64"]
326326
msvc_runtime: ["static", "dynamic"]
327327
linux_abi: ["legacy", "c++11"]
328328
python_version: [3.9]
329329
include:
330-
- os: windows-latest
330+
- os: windows-2022
331331
vcpkg_triplet_suffix: "windows-static"
332332
sdk_platform: "windows"
333-
- os: windows-latest
333+
- os: windows-2022
334334
msvc_runtime: "dynamic"
335335
vcpkg_triplet_suffix: "windows-static-md"
336336
sdk_platform: "windows"
@@ -344,7 +344,7 @@ jobs:
344344
sdk_platform: "darwin"
345345

346346
exclude:
347-
- os: windows-latest
347+
- os: windows-2022
348348
linux_abi: "c++11"
349349
- os: macos-15
350350
architecture: "x86"
@@ -360,7 +360,7 @@ jobs:
360360
build_type: "Debug"
361361
- os: ubuntu-22.04
362362
architecture: "arm64"
363-
- os: windows-latest
363+
- os: windows-2022
364364
architecture: "arm64"
365365

366366
steps:

.github/workflows/desktop.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,11 @@ jobs:
6060
python_version: ${{ fromJson(needs.prepare_matrix.outputs.matrix_python_version) }}
6161
include:
6262
# More Windows combinations are in the expanded matrix.
63-
- os: windows-latest
63+
- os: windows-2022
6464
build_type: "Release"
6565
architecture: "x64"
6666
msvc_runtime: "static"
67-
- os: windows-latest
67+
- os: windows-2022
6868
build_type: "Debug"
6969
architecture: "x86"
7070
msvc_runtime: "dynamic"
@@ -82,16 +82,16 @@ jobs:
8282
# Xcode excludes -- allow only one on osx and linux
8383
- os: ubuntu-22.04
8484
xcode_version: "11.7"
85-
- os: windows-latest
85+
- os: windows-2022
8686
xcode_version: "11.7"
8787
- os: ubuntu-22.04
8888
xcode_version: "12.5.1"
89-
- os: windows-latest
89+
- os: windows-2022
9090
xcode_version: "12.5.1"
9191
# arm64 is only for macos
9292
- os: ubuntu-22.04
9393
architecture: "arm64"
94-
- os: windows-latest
94+
- os: windows-2022
9595
architecture: "arm64"
9696
# arm64 can't be built on Xcode 11
9797
- xcode_version: "11.7"
@@ -190,6 +190,7 @@ jobs:
190190
python-version: ${{ matrix.python_version }}
191191
architecture: ${{ matrix.architecture }}
192192

193+
193194
- name: Install Desktop SDK prerequisites
194195
uses: nick-invision/retry@v2
195196
with:

.github/workflows/integration_tests.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ on:
2121
required: true
2222
operating_systems:
2323
description: 'CSV of VMs to run on'
24-
default: 'ubuntu-22.04,windows-latest,macos-15'
24+
default: 'ubuntu-22.04,windows-2022,macos-15'
2525
required: true
2626
desktop_ssl_variants:
2727
description: 'CSV of desktop SSL variants to use'
@@ -278,7 +278,7 @@ jobs:
278278
# places.
279279
exclude:
280280
# Do not attempt to use arm64 on Windows or Linux.
281-
- os: windows-latest
281+
- os: windows-2022
282282
arch: arm64
283283
- os: ubuntu-22.04
284284
arch: arm64
@@ -289,7 +289,7 @@ jobs:
289289
# system's openssl when cross-compiling, except on Linux. Builds on Linux
290290
# happen on x64 machines, so x86 is technically cross-compiling. Builds on
291291
# Mac happen on arm64 machines, so x64 is technically cross-compiling.
292-
- os: windows-latest
292+
- os: windows-2022
293293
ssl_variant: openssl
294294
arch: x86
295295
- os: macos-15
@@ -848,7 +848,7 @@ jobs:
848848
# places.
849849
exclude:
850850
# Do not attempt to use arm64 on Windows or Linux.
851-
- os: windows-latest
851+
- os: windows-2022
852852
arch: arm64
853853
- os: ubuntu-22.04
854854
arch: arm64
@@ -859,7 +859,7 @@ jobs:
859859
# system's openssl when cross-compiling, except on Linux. Builds on Linux
860860
# happen on x64 machines, so x86 is technically cross-compiling. Builds on
861861
# Mac happen on arm64 machines, so x64 is technically cross-compiling.
862-
- os: windows-latest
862+
- os: windows-2022
863863
ssl_variant: openssl
864864
arch: x86
865865
- os: macos-15

scripts/gha/print_matrix_configuration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,27 +81,27 @@
8181
"python_version": ["3.9"],
8282

8383
EXPANDED_KEY: {
84-
"os": ["ubuntu-22.04", "macos-15", "windows-latest"],
84+
"os": ["ubuntu-22.04", "macos-15", "windows-2022"],
8585
"xcode_version": ["26.2"],
8686
}
8787
}
8888
},
8989

9090
"android": {
9191
"matrix": {
92-
"os": ["ubuntu-22.04", "macos-15", "windows-latest"],
92+
"os": ["ubuntu-22.04", "macos-15", "windows-2022"],
9393
"architecture": ["x64", "arm64"],
9494
"python_version": ["3.9"],
9595

9696
EXPANDED_KEY: {
97-
"os": ["ubuntu-22.04", "macos-15", "windows-latest"]
97+
"os": ["ubuntu-22.04", "macos-15", "windows-2022"]
9898
}
9999
}
100100
},
101101

102102
"integration_tests": {
103103
"matrix": {
104-
"os": ["ubuntu-22.04", "macos-15", "windows-latest"],
104+
"os": ["ubuntu-22.04", "macos-15", "windows-2022"],
105105
"platform": ["Desktop", "Android", "iOS", "tvOS"],
106106
"ssl_lib": ["openssl"],
107107
"android_device": ["android_target", "emulator_ftl_target"],

0 commit comments

Comments
 (0)