Remove Dynamic Links and Invites#1766
Closed
jonsimantov wants to merge 2 commits intomainfrom
Closed
Conversation
This commit removes the deprecated Dynamic Links SDK and all related Invites code from the Firebase C++ SDK. Changes made: - Deleted the `dynamic_links` directory. - Deleted `app/src/invites/` and `app/invites_resources/`. - Updated CMakeLists.txt files (root, app, release_build_files) to remove references to `dynamic_links` and `invites`. - Updated Gradle build files (Android/firebase_dependencies.gradle, release_build_files/Android/firebase_dependencies.gradle, settings.gradle) to remove `dynamic_links` and `invites` dependencies and resource references. - Updated build scripts (build_scripts/ios/build.sh, build_scripts/packaging.conf) to remove `dynamic_links`. - Updated GitHub Actions workflows (.github/workflows/cpp-packaging.yml, .github/workflows/integration_tests.yml) to remove `dynamic_links`. Next steps involve removing test configurations and documentation related to Dynamic Links and Invites.
jonsimantov
added
the
tests-requested: full
github-actions
Bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @jonsimantov on commit 12d2bbe
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the deprecated Dynamic Links SDK and all related Invites code from the Firebase C++ SDK.
Changes made:
dynamic_linksdirectory.app/src/invites/andapp/invites_resources/.dynamic_linksandinvites.dynamic_linksandinvitesdependencies and resource references.dynamic_links.dynamic_links.Next steps involve removing test configurations and documentation related to Dynamic Links and Invites.
Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.