Skip to content

Update upload-symbols with better logging and reading DEVELOPER_DIR to get Xcode path for CoreSymbolication#16007

Merged
tejasd merged 4 commits intomainfrom
td/upload-symbols
Apr 7, 2026
Merged

Update upload-symbols with better logging and reading DEVELOPER_DIR to get Xcode path for CoreSymbolication#16007
tejasd merged 4 commits intomainfrom
td/upload-symbols

Conversation

@tejasd
Copy link
Copy Markdown
Contributor

@tejasd tejasd commented Mar 30, 2026

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

This is based on feedback in #15896.

Testing

  • Verified w/ integration test
  • Verified locally

API Changes

This change reads environment variable DEVELOPER_DIR in upload-symbols for CoreSymbolication.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@tejasd tejasd changed the title [DO NOT SUBMIT] Update upload-symbols with updated logging and environment variable Update upload-symbols with better logging and reading DEVELOPER_DIR to get Xcode path for CoreSymbolication Mar 31, 2026
@tejasd tejasd requested review from mghaznav and ncooke3 April 1, 2026 17:56
@tejasd tejasd marked this pull request as ready for review April 1, 2026 17:56
@tejasd tejasd requested a review from elenadoty April 1, 2026 18:00
@tejasd
Copy link
Copy Markdown
Contributor Author

tejasd commented Apr 1, 2026

Instructions for reviewing this (since it's a binary):

  • ./upload-symbols --version
  • codesign -dv --verbose=2 upload-symbols

Comment thread Crashlytics/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for changelog

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
@tejasd tejasd merged commit df0a71a into main Apr 7, 2026
64 of 65 checks passed
@tejasd tejasd deleted the td/upload-symbols branch April 7, 2026 14:31
ncooke3 added a commit that referenced this pull request Apr 9, 2026
… to get Xcode path for CoreSymbolication (#16007)

Co-authored-by: Nick Cooke <36927374+ncooke3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants