Optimize Firestore CI and Migrate Test Retries to xcodebuild#16024
Optimize Firestore CI and Migrate Test Retries to xcodebuild#16024cherylEnkidu merged 12 commits intomainfrom
xcodebuild#16024Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Generated by 🚫 Danger |
Remove the intentional failure
xcodebuild
This PR introduces optimizations to the Firestore CI workflows and refactors the test retry mechanism to use native Xcode features instead of a GitHub Action.
Key Changes
CI Optimization (
.github/workflows/sdk.firestore.yml)Firestore/Example/Podsinxcodetest,xcodetest_nightly, andxcodetest_emulatorjobs to speed up CI runs.nick-fields/retryGitHub Action for running tests. Tests are now executed directly viascripts/build.sh.Build Script Updates (
scripts/build.sh)xcodebuildby adding-retry-tests-on-failureand-test-iterations 3flags for Firestore integration tests. This allows individual failing tests to be retried rather than rerunning the entire suite via the CI workflow.Project File Updates (
Firestore/Example/Firestore.xcodeproj/project.pbxproj)AsyncSequenceTests.swiftin the project structure.Test Fixes (
Firestore/Swift/Tests/Integration/PipelineTests.swift)testSupportsParent: Updated the test to userandomCol.firestoreinstead of creating a new instance withfirestore(), ensuring the correct database instance is used.arrayTransform.