Skip to content

[SPM] Fix unfound file warnings from swift build#16041

Merged
paulb777 merged 11 commits intomainfrom
pb-fix-package-exclusions
Apr 10, 2026
Merged

[SPM] Fix unfound file warnings from swift build#16041
paulb777 merged 11 commits intomainfrom
pb-fix-package-exclusions

Conversation

@paulb777
Copy link
Copy Markdown
Member

@paulb777 paulb777 commented Apr 4, 2026

Fix #16012
The Pull Request #16041 in the firebase-ios-sdk repository aims to fix "file not found" warnings that occur during Swift Package Manager (SPM) builds.

Key Changes

  • Fixing Build Warnings: The primary goal is to resolve warnings triggered by swift build related to missing or incorrectly referenced files.

  • Package.swift Updates: Modifications were made to the Package.swift file to refine how paths and exclusions are handled. This includes:

    • Updating paths for FirebaseCrashlyticsSwift.
    • Cleaning up trailing slashes in path strings (e.g., changing "ProtoSupport/" to "ProtoSupport").
    • Consolidating source and exclusion lists to ensure the build system correctly identifies the intended files.
  • Documentation Consolidation: A significant number of small AGENTS.md files scattered throughout the FirebaseAI directory were deleted and replaced with a single, comprehensive FirebaseAI/AGENTS.md. This new file serves as a "Codebase Map" to help AI agents navigate the SDK structure.

  • Changelog Updates: The CHANGELOG.md files for both Crashlytics and FirebaseAI were updated to reflect these fixes.

Statistics

  • Files changed: 19
  • Additions: 187
  • Deletions: 286

In short, it’s a cleanup PR focused on improving SPM reliability and streamlining internal documentation for better AI-assisted development.

@paulb777 paulb777 requested a review from a team as a code owner April 4, 2026 01:19
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@paulb777
Copy link
Copy Markdown
Member Author

paulb777 commented Apr 4, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves "unfound file" warnings during swift build by refining path definitions and exclusions within Package.swift. Key changes include adding a comprehensive exclusion list for the FirebaseAI target and standardizing directory paths by removing trailing slashes. Review feedback identifies a duplicate UnitTests entry in the Crashlytics exclusion list and suggests further path normalization for consistency, specifically removing a trailing slash from the FirebaseCrashlyticsSwift path and simplifying the source path from ./ to ..

Comment thread Package.swift Outdated
Comment thread Package.swift Outdated
Comment thread Package.swift Outdated
@paulb777 paulb777 added this to the 12.13.0 - M180 milestone Apr 4, 2026
@paulb777 paulb777 requested a review from ncooke3 April 4, 2026 15:28
Comment thread Package.swift Outdated
@paulb777
Copy link
Copy Markdown
Member Author

paulb777 commented Apr 9, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates AI agent documentation for the FirebaseAI module into a single AGENTS.md file and resolves swift build warnings by refining path specifications in Package.swift. Specifically, trailing slashes were removed from directory paths, and the FirebaseCrashlyticsSwift target path was updated. Feedback suggests further simplifying the FirebaseCrashlyticsSwift target by removing the redundant sources parameter, as the path already points to the source directory.

Comment thread Package.swift Outdated
@paulb777
Copy link
Copy Markdown
Member Author

paulb777 commented Apr 9, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses unfound file warnings from 'swift build' by updating the Package.swift configuration and cleaning up the project structure. It also adds a new codebase map for FirebaseAI and updates the changelogs. The reviewer requested verification of the path 'Crashlytics/Crashlytics/Rollouts' in Package.swift, as it appears potentially redundant.

Comment thread Package.swift
@paulb777 paulb777 requested a review from ncooke3 April 10, 2026 00:59
@paulb777 paulb777 merged commit 4ab415e into main Apr 10, 2026
112 checks passed
@paulb777 paulb777 deleted the pb-fix-package-exclusions branch April 10, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SwiftPM warning "found unhandled files" when building firebase-ios-sdk via swift build

2 participants