[SPM] Fix unfound file warnings from swift build#16041
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
2b87648 to
72dc5a9
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request resolves "unfound file" warnings during swift build by refining path definitions and exclusions within Package.swift. Key changes include adding a comprehensive exclusion list for the FirebaseAI target and standardizing directory paths by removing trailing slashes. Review feedback identifies a duplicate UnitTests entry in the Crashlytics exclusion list and suggests further path normalization for consistency, specifically removing a trailing slash from the FirebaseCrashlyticsSwift path and simplifying the source path from ./ to ..
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request consolidates AI agent documentation for the FirebaseAI module into a single AGENTS.md file and resolves swift build warnings by refining path specifications in Package.swift. Specifically, trailing slashes were removed from directory paths, and the FirebaseCrashlyticsSwift target path was updated. Feedback suggests further simplifying the FirebaseCrashlyticsSwift target by removing the redundant sources parameter, as the path already points to the source directory.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request addresses unfound file warnings from 'swift build' by updating the Package.swift configuration and cleaning up the project structure. It also adds a new codebase map for FirebaseAI and updates the changelogs. The reviewer requested verification of the path 'Crashlytics/Crashlytics/Rollouts' in Package.swift, as it appears potentially redundant.
Fix #16012
The Pull Request #16041 in the
firebase-ios-sdkrepository aims to fix "file not found" warnings that occur during Swift Package Manager (SPM) builds.Key Changes
Fixing Build Warnings: The primary goal is to resolve warnings triggered by
swift buildrelated to missing or incorrectly referenced files.Package.swift Updates: Modifications were made to the
Package.swiftfile to refine how paths and exclusions are handled. This includes:FirebaseCrashlyticsSwift."ProtoSupport/"to"ProtoSupport").Documentation Consolidation: A significant number of small
AGENTS.mdfiles scattered throughout theFirebaseAIdirectory were deleted and replaced with a single, comprehensive FirebaseAI/AGENTS.md. This new file serves as a "Codebase Map" to help AI agents navigate the SDK structure.Changelog Updates: The
CHANGELOG.mdfiles for both Crashlytics and FirebaseAI were updated to reflect these fixes.Statistics
In short, it’s a cleanup PR focused on improving SPM reliability and streamlining internal documentation for better AI-assisted development.