Skip to content

fix(auth): handle external sign-in callbacks when using scene delegates in sample app #16261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daymxn wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −3
Open

fix(auth): handle external sign-in callbacks when using scene delegates in sample app #16261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions FirebaseAuth/Tests/SampleSwift/AuthenticationExample/SceneDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

import FirebaseAuth
import UIKit
import GoogleSignIn
import FacebookCore

class SceneDelegate: UIResponder, UIWindowSceneDelegate {
var window: UIWindow?
Expand Down Expand Up @@ -53,10 +55,24 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
func scene(_ scene: UIScene, openURLContexts URLContexts: Set<UIOpenURLContext>) {
for urlContext in URLContexts {
let url = urlContext.url
_ = Auth.auth().canHandle(url)
if Auth.auth().canHandle(url) {
continue;
}
// Handle Google signins
if GIDSignIn.sharedInstance.handle(url) {
continue;
}
// Handle Facebook signins
if ApplicationDelegate.shared.application(
UIApplication.shared,
open: url,
sourceApplication: urlContext.options.sourceApplication,
annotation: urlContext.options.annotation
) {
continue
}
// URL not auth, Google, or Facebook related; it should be handled separately.
}

// URL not auth related; it should be handled separately.
}

func scene(_ scene: UIScene, continue userActivity: NSUserActivity) {
Expand Down
Loading