-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor(misc): remove obsolete OS availability checks #16313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -407,7 +407,7 @@ enum FunctionsConstants { | |||||||
| } | ||||||||
| } | ||||||||
|
|
||||||||
| @available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *) | ||||||||
| @available(macOS 12.0, watchOS 8.0, *) | ||||||||
| func stream(at url: URL, | ||||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this remain, minus the iOS and tvOS bits?
Suggested change
|
||||||||
| data: SendableWrapper?, | ||||||||
| options: HTTPSCallableOptions?, | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -165,7 +165,7 @@ public final class HTTPSCallable: NSObject, Sendable { | |||||||
| .callFunction(at: url, withObject: data, options: options, timeout: timeoutInterval) | ||||||||
| } | ||||||||
|
|
||||||||
| @available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *) | ||||||||
| @available(macOS 12.0, watchOS 8.0, *) | ||||||||
| func stream(_ data: SendableWrapper? = nil) -> AsyncThrowingStream<JSONStreamResponse, Error> { | ||||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this remain, minus the iOS and tvOS bits?
Suggested change
|
||||||||
| functions.stream(at: url, data: data, options: options, timeout: timeoutInterval) | ||||||||
| } | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -895,7 +895,7 @@ class IntegrationTests: XCTestCase { | |||||||
| /// indicate the callable function does not accept parameters. | ||||||||
| private struct EmptyRequest: Encodable, Sendable {} | ||||||||
|
|
||||||||
| @available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *) | ||||||||
| @available(macOS 12.0, watchOS 8.0, *) | ||||||||
| extension IntegrationTests { | ||||||||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this remain, minus the iOS and tvOS bits?
Suggested change
|
||||||||
| func testStream_NoArgs() async throws { | ||||||||
| // 1. Custom `EmptyRequest` struct is passed as a placeholder generic arg. | ||||||||
|
|
||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this remain, minus the iOS and tvOS bits?