Skip to content

chore(gemfile): concurrent-ruby >= 1.3.7#16316

Merged
ncooke3 merged 3 commits into
mainfrom
nc.gemfile.concurrent-ruby
Jun 24, 2026
Merged

chore(gemfile): concurrent-ruby >= 1.3.7#16316
ncooke3 merged 3 commits into
mainfrom
nc.gemfile.concurrent-ruby

Conversation

@ncooke3

@ncooke3 ncooke3 commented Jun 23, 2026

Copy link
Copy Markdown
Member

#no-changelog

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Comment thread Gemfile Outdated
Comment thread Gemfile.lock Outdated
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 temporarily deployed to release-testing June 23, 2026 22:51 — with GitHub Actions Inactive
@ncooke3 ncooke3 marked this pull request as ready for review June 23, 2026 22:55
@ncooke3 ncooke3 requested a review from a team as a code owner June 23, 2026 22:55

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on acceptable CI

@ncooke3

ncooke3 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Integration flakes and Firestore job does not have dependency on Ruby.

Viewed sdk.firestore.yml:1-701

Based on the sdk.firestore.yml workflow file, the sanitizers-mac job does not have an explicit dependency on any particular Ruby version.

Unlike other jobs in that workflow (such as xcodetest_prod or pod-lib-lint-cron which explicitly use the ruby/setup-ruby action), the sanitizers-mac job only sets up Python and CMake:

    - uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
      with:
        python-version: '3.11'

    - name: Setup cmake
      uses: jwlawson/actions-setup-cmake@802fa1a2c4e212495c05bf94dba2704a92a472be
      with:
        cmake-version: '3.31.2'

Any Ruby scripts called downstream (e.g., inside install_prereqs.sh or build.sh) would just end up using the system default Ruby provided by the macos-26 runner environment.

@ncooke3 ncooke3 merged commit bb122d6 into main Jun 24, 2026
784 of 789 checks passed
@ncooke3 ncooke3 deleted the nc.gemfile.concurrent-ruby branch June 24, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants