Skip to content

Commit 2da66b6

Browse files
authored
ci: fix storage emulator integration tests on Node 24 (#10641)
* ci: run GHA integration tests on Node 22 ### Description Node 20 is being deprecated from GitHub Actions. As part of upgrading our workflow: - The integration and integration-windows jobs have been updated to run on Node 22 (Active LTS). - This prevents a compatibility crash between the repository's Puppeteer v19 dependency and Node 24 (which clobbers file descriptors during child process spawning, causing Chrome to fail to launch with 'Invalid file descriptor to ICU data received'). - Other non-browser, single-version jobs remain on Node 24. - Multi-version jobs continue to cover Node 22 and 24. ### Scenarios Tested - Verified all GHA workflows, compilation, unit tests, and storage emulator integration tests pass successfully on GHA Node 22. ### Sample Commands None * ci: target Node 22 for storage-emulator-integration and Node 24 for all other integration tests This meets the GHA Node 20 deprecation rules by keeping all integration and windows-integration tests on Node 24, except the storage-emulator-integration test which runs on Node 22 (LTS) to avoid Puppeteer v19 compatibility crashes with Node 24. * clean up include block
1 parent 17eb99b commit 2da66b6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/node-test.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -209,14 +209,14 @@ jobs:
209209
# - npm run test:hosting-rewrites # Long-running test that might conflict across test runs. Run this manually.
210210
- npm run test:import-export
211211
- npm run test:storage-deploy
212-
- npm run test:storage-emulator-integration
213212
- npm run test:triggers-end-to-end
214213
- npm run test:triggers-end-to-end:inspect
215214
# - npm run test:dataconnect-deploy
216215
- npm run test:dataconnect-emulator
216+
- npm run test:functions-discover
217217
include:
218-
- node-version: "24"
219-
script: "npm run test:functions-discover"
218+
- node-version: "22"
219+
script: "npm run test:storage-emulator-integration"
220220
steps:
221221
- uses: actions/checkout@v4
222222
- uses: actions/setup-node@v3

0 commit comments

Comments
 (0)