Skip to content

Commit f6ae3b4

Browse files
authored
[VSCODE] Fix hover cursor and styling on Configure emulator link (#10623)
1 parent 33ff901 commit f6ae3b4

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

firebase-vscode/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
- [Changed] Rename "Run (local)" code lens to "Run (Emulator)".
44
- [Fixed] Fix auth issue from Generate Operation button by skipping unnecessary schema compilation check.
5+
- [Fixed] 'Configure emulator' link hover does not hint it's clickable.
56
- [Changed] Replace generateSchema and generateQuery backends with the new fdc AgentService API.
67
- [Added] Improved error handling and status updates for query generation
78
- [Added] Local schema aware query generation

firebase-vscode/webviews/SidebarApp.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { ProjectSection } from "./components/ProjectSection";
66
import {
77
VSCodeButton,
88
VSCodeDropdown,
9+
VSCodeLink,
910
VSCodeOption,
1011
VSCodeProgressRing,
1112
} from "@vscode/webview-ui-toolkit/react";
@@ -107,13 +108,16 @@ function EmulatorsPanel() {
107108
</VSCodeButton>
108109
<Spacer size="xsmall" />
109110
<Label level={3}>
110-
<a
111-
onClick={() => {
111+
<VSCodeLink
112+
href="#"
113+
style={{ fontSize: "inherit", fontWeight: "inherit" }}
114+
onClick={(e) => {
115+
e.preventDefault();
112116
broker.send("fdc.open-emulator-settings");
113117
}}
114118
>
115119
Configure emulator
116-
</a>
120+
</VSCodeLink>
117121
</Label>
118122
<Label level={3}>
119123
See also:{" "}

0 commit comments

Comments
 (0)