PR feedback

Author: inlined

src/functions/iac/export.spec.ts

@@ -14,16 +14,18 @@ describe("export", () => {
 
   const mockDelegate = {
     language: "nodejs",
-    runtime: "nodejs18",
+    runtime: supported.latest("nodejs"),
     validate: sinon.stub(),
     build: sinon.stub(),
     discoverBuild: sinon.stub(),
-  };
+    bin: "node",
+    watch: sinon.stub(),
+  } as const;
 
   beforeEach(() => {
     sinon.stub(functionsConfig, "getFirebaseConfig").resolves({ projectId: "my-project" });
     sinon.stub(functionsEnv, "loadFirebaseEnvs").returns({});
-    sinon.stub(runtimes, "getRuntimeDelegate").resolves(mockDelegate as any);
+    sinon.stub(runtimes, "getRuntimeDelegate").resolves(mockDelegate);
     sinon.stub(supported, "guardVersionSupport");
     needProjectIdStub = sinon.stub(projectUtils, "needProjectId").returns("my-project");
   });
@@ -44,7 +46,7 @@ describe("export", () => {
       const codebase: projectConfig.ValidatedSingle = {
         source: "src",
         codebase: "default",
-        runtime: "nodejs18",
+        runtime: supported.latest("nodejs") as supported.ActiveRuntime,
       };
 
       const result = await exportIac.getInternalIac(options, codebase);
@@ -57,5 +59,32 @@ describe("export", () => {
         "functions.yaml": yaml.dump(mockBuild),
       });
     });
+
+    it("should throw if codebase has no source", async () => {
+      const options = { config: { path: (s: string) => s, projectDir: "dir" } };
+      const codebase: projectConfig.ValidatedSingle = {
+        codebase: "default",
+        runtime: supported.latest("nodejs") as supported.ActiveRuntime,
+      } as unknown as projectConfig.ValidatedSingle;
+
+      await expect(exportIac.getInternalIac(options, codebase)).to.be.rejectedWith(
+        "Cannot export a codebase with no source",
+      );
+    });
+
+    it("should throw an error if discoverBuild fails", async () => {
+      mockDelegate.discoverBuild.rejects(new Error("Failed to discover build"));
+
+      const options = { config: { path: (s: string) => s, projectDir: "dir" } };
+      const codebase: projectConfig.ValidatedSingle = {
+        source: "src",
+        codebase: "default",
+        runtime: supported.latest("nodejs") as supported.ActiveRuntime,
+      };
+
+      await expect(exportIac.getInternalIac(options, codebase)).to.be.rejectedWith(
+        "Failed to discover build",
+      );
+    });
   });
 });

src/functions/iac/export.ts

@@ -6,27 +6,31 @@ import * as functionsEnv from "../../functions/env";
 import { logger } from "../../logger";
 import * as yaml from "js-yaml";
 import { needProjectId } from "../../projectUtils";
+import { FirebaseError } from "../../error";
 
 export type Exporter = (
   options: any,
   codebase: projectConfig.ValidatedSingle,
 ) => Promise<Record<string, string>>;
 
 /**
- *
+ * Exports the functions.yaml format of the codebase.
  */
 export async function getInternalIac(
   options: any,
   codebase: projectConfig.ValidatedSingle,
 ): Promise<Record<string, string>> {
+  if (!codebase.source) {
+    throw new FirebaseError("Cannot export a codebase with no source");
+  }
   const projectId = needProjectId(options);
 
   const firebaseConfig = await functionsConfig.getFirebaseConfig(options);
   const firebaseEnvs = functionsEnv.loadFirebaseEnvs(firebaseConfig, projectId);
 
   const delegateContext: runtimes.DelegateContext = {
     projectId,
-    sourceDir: options.config.path(codebase.source!),
+    sourceDir: options.config.path(codebase.source),
     projectDir: options.config.projectDir,
     runtime: codebase.runtime,
   };