Warn the user if their local build output is larger than 250MB#10439
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a size limit check for local build artifacts in App Hosting, throwing a FirebaseError if the generated tarball exceeds the specified limit (defaulting to 250MB). Review feedback highlights that the implementation currently ignores the config.ignore field, which prevents users from excluding files to stay under the limit. Additionally, it is recommended to replace the magic number used for the size limit with a named constant to improve code maintainability.
…size check to warning
…ning # Conflicts: # src/deploy/apphosting/util.spec.ts # src/deploy/apphosting/util.ts
…builds_size_warning
Yuangwang
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cloud Run only supports 250MB maximum size for zip deploys
Scenarios Tested
Sample Commands