fix failing tests if fdcrealtime experiment is disabled locally#10493
Open
aalej wants to merge 3 commits into
Open
fix failing tests if fdcrealtime experiment is disabled locally#10493aalej wants to merge 3 commits into
aalej wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the unit tests in src/init/features/dataconnect/sdk.spec.ts by wrapping several SDK generation test cases within a new describe block that stubs the fdcrealtime experiment as enabled. This ensures that the tests for JavaScript, Dart, Kotlin, and Swift SDK generation are specifically validated under the context of this experiment. I have no feedback to provide as there were no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some tests were failing because I had the
fdcrealtimedisabled locallyScenarios Tested
npm run testSample Commands