Update CHANGELOG.md for #10503#10513
Closed
Berlioz wants to merge 1 commit into
Closed
Conversation
Forgot to update it in the PR itself.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md to include a new entry regarding the automatic upserting of IAM bindings for AI Logic functions during deployment. The review feedback suggests a minor stylistic refinement to the changelog entry to improve professionalism and consistency by removing redundant language.
| - Added support for nested 1:Many relational batch mutations. | ||
| - Updated the Golang dependency version to 1.25.10. | ||
| - Default timeout for Dart functions is now 60 seconds when not explicitly set (#10501) | ||
| - Now upserts the required IAM bindings to invoke AI Logic functions upon deployment (#10503) |
Contributor
There was a problem hiding this comment.
The word "Now" is redundant in a changelog entry. It is more professional and consistent with other entries in this file to start directly with a verb.
Suggested change
| - Now upserts the required IAM bindings to invoke AI Logic functions upon deployment (#10503) | |
| - Automatically upserts the required IAM bindings to invoke AI Logic functions upon deployment (#10503) |
Contributor
Author
|
Redundant with #10514 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot to update it in the PR itself.