Skip to content

Add missing changelog entries#10514

Merged
christhompsongoogle merged 1 commit into
mainfrom
ajp-update-changelog
May 13, 2026
Merged

Add missing changelog entries#10514
christhompsongoogle merged 1 commit into
mainfrom
ajp-update-changelog

Conversation

@ajperel
Copy link
Copy Markdown
Contributor

@ajperel ajperel commented May 13, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@shettyvarun268 shettyvarun268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the changelog to include support for secret environment variables in Cloud Run functions and project bindings for AI Logic services. Feedback was provided regarding the missing structured PR description required by the style guide and the need to rephrase the AI Logic changelog entry to use user-facing language instead of internal implementation details.

Comment thread CHANGELOG.md
- Added support for nested 1:Many relational batch mutations.
- Updated the Golang dependency version to 1.25.10.
- Default timeout for Dart functions is now 60 seconds when not explicitly set (#10501)
- Support secret environment variables for Cloud Run functions (#10489)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request description is empty. According to the repository style guide (GEMINI.md, line 53), the PR description should follow a structured format including ### Description, ### Scenarios Tested, and ### Sample Commands to provide context for the changes.

References
  1. The pull request description should follow a structured format including Description, Scenarios Tested, and Sample Commands as per the repository's best practices. (link)

Comment thread CHANGELOG.md
- Updated the Golang dependency version to 1.25.10.
- Default timeout for Dart functions is now 60 seconds when not explicitly set (#10501)
- Support secret environment variables for Cloud Run functions (#10489)
- Set requiredProjectBindings in AI Logic services (#10503)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The changelog entry "Set requiredProjectBindings in AI Logic services" uses internal implementation details (requiredProjectBindings). Changelog entries should be written for end-users and describe the impact or feature in a way they understand.

Suggested change
- Set requiredProjectBindings in AI Logic services (#10503)
- Automatically configure necessary IAM permissions for AI Logic triggers (#10503)

@christhompsongoogle christhompsongoogle merged commit 0e759e4 into main May 13, 2026
79 of 81 checks passed
@christhompsongoogle christhompsongoogle deleted the ajp-update-changelog branch May 13, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants