add release vscode workflow; fix changelog#10719
Open
hlshen wants to merge 9 commits into
Open
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fredzqm
approved these changes
Jun 25, 2026
joehan
approved these changes
Jun 26, 2026
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
Seems fine once we change the branch name
joehan
reviewed
Jun 26, 2026
joehan
requested changes
Jun 26, 2026
morganchen12
requested changes
Jun 26, 2026
joehan
approved these changes
Jun 26, 2026
Comment on lines
+32
to
+34
| TARGET_BRANCH="vscode-release-trigger-build-only" | ||
| else | ||
| TARGET_BRANCH="vscode-release-trigger" |
Contributor
There was a problem hiding this comment.
Given these are going to be origins for release artifacts, you should work with Joe to set up branch protections for these branches.
joehan
reviewed
Jun 26, 2026
| github.event.issue.pull_request && | ||
| startsWith(github.event.comment.body, '/run-release') && | ||
| (github.event.comment.author_association == 'OWNER' || | ||
| github.event.comment.author_association == 'MEMBER' || |
Member
There was a problem hiding this comment.
Lets also assert that the pr aiuthor is an owner or maintainer as well. I don't think we'd ever run this on a contributor branch, but we should encode that into the rule
| jobs: | ||
| release: | ||
| if: | | ||
| github.event.issue.pull_request && |
Contributor
There was a problem hiding this comment.
Please also add an author check here.
(github.event.issue.author_association == 'OWNER' ||
github.event.issue.author_association == 'MEMBER')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a release-vscode-ext workflow, used to trigger the Kokoro build, sign, and publish pipeline.