Skip to content

Add List storage API to Unity SDK#1434

Merged
AustinBenoit merged 4 commits intomainfrom
unity-list-all
Apr 22, 2026
Merged

Add List storage API to Unity SDK#1434
AustinBenoit merged 4 commits intomainfrom
unity-list-all

Conversation

@AustinBenoit
Copy link
Copy Markdown
Contributor

@AustinBenoit AustinBenoit commented Apr 21, 2026 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Add List storage API to Unity SDK

Testing

Describe how you've tested these changes.

New integration tests and a local run on iOS.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the ListAsync API to the Firebase Storage SDK, allowing users to list items and prefixes under a reference. The changes include the addition of the StorageListResult class, the ListAsync method in StorageReference, updated SWIG bindings, and new automated tests. Feedback focuses on optimizing list initialization by setting capacity, improving API usability by using IReadOnlyList for result collections, and renaming parameters for cross-SDK consistency. Additionally, improvements to the automated tests were suggested to prevent flakiness and ensure proper assertions are made.

Comment thread storage/src/StorageListResult.cs Outdated
Comment thread storage/src/StorageListResult.cs Outdated
Comment thread storage/src/StorageReference.cs Outdated
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs Outdated
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs Outdated
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs Outdated
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs Outdated
@AustinBenoit AustinBenoit added the tests-requested: quick Trigger a quick set of integration tests. label Apr 21, 2026
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 21, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026 •
edited
Loading

✅  Integration test succeeded!

Requested by @firebase-workflow-trigger[bot] on commit d2ee847
Last updated: Wed Apr 22 10:49 PDT 2026
View integration test log & download artifacts

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Apr 21, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 21, 2026
@AustinBenoit AustinBenoit changed the title Add List API to Unity SDK Add List storage API to Unity SDK Apr 21, 2026
@AustinBenoit
Copy link
Copy Markdown
Contributor Author

AustinBenoit commented Apr 21, 2026

Add List storage API to Unity SDK

https://github.com/firebase/firebase-unity-sdk/actions/runs/24738343429 Has some failures but none related to storage. Should be good to go.

@AustinBenoit AustinBenoit requested a review from a-maurice April 21, 2026 19:33
a-maurice
a-maurice reviewed Apr 21, 2026
View reviewed changes
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs Outdated
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs Outdated
Comment thread storage/testapp/Assets/Firebase/Sample/Storage/UIHandlerAutomated.cs
@AustinBenoit AustinBenoit added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Apr 22, 2026
@github-actions github-actions Bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 22, 2026
@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label Apr 22, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 22, 2026
@AustinBenoit AustinBenoit merged commit 07a7304 into main Apr 22, 2026
28 checks passed
@AustinBenoit AustinBenoit deleted the unity-list-all branch April 22, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-maurice a-maurice a-maurice approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AustinBenoit @a-maurice