Fix report build script#1437
Merged
AustinBenoit merged 3 commits intomainfrom Apr 22, 2026
Merged
Conversation
1. Check run conclusion before defaulting to unknown error when log parsing fails 2. Upload combined build_and_test_results artifact so report script can find it
AustinBenoit
added
the
tests-requested: quick
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the build status reporting script to correctly identify successful integration tests even when specific failure log patterns are not found, provided the run conclusion is 'success'. A review comment suggests simplifying the implementation by removing redundant variable assignments and adding logging to maintain consistency with other parts of the script.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
github-actions
Bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @firebase-workflow-trigger[bot] on commit c702a19 |
github-actions
Bot
added
the
tests: succeeded
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
a-maurice
approved these changes
Apr 22, 2026
cynthiajoan
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem: The nightly integration test reporting script (report_build_status.py) was incorrectly marking successful test runs (specifically the "Test Build" and "Firestore Test Build" columns) as failures.
This happened due to a combination of two issues:
Missing Combined Artifact: The summarize-results job in integration_tests.yml downloaded and merged all the fragmented build_and_test_results-* artifacts, but it never uploaded the final combined build_and_test_results artifact. As a result, the reporting script could never find the artifact and was forced to parse the raw GitHub text logs instead.
Aggressive Fallback Logic: When parsing the raw logs of a fully successful run, the INTEGRATION TEST FAILURES block is naturally absent. Instead of recognizing the run as successful, the fallback logic incorrectly assumed the summary string was missing and injected a generic [BUILD] [ERROR] Unknown Error string, which was then parsed as a hard failure.
Solution:
integration_tests.yml: Added an actions/upload-artifact step to upload the combined build_and_test_results artifact at the end of the summarize-results job. This allows the reporting script to bypass text log scraping and parse the structured JSON directly (which is significantly faster and more reliable).
report_build_status.py: Updated the fallback logic to check if the workflow run's conclusion is
Testing
Ran test to make sure they don't break
Type of Change
Place an
xthe applicable box: