Strip debug symbols from the Apple libraries#1443
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces symbol stripping for macOS builds in both build_shared.cmake and build_universal.cmake using linker options and post-build commands. Feedback suggests restricting this stripping to non-debug builds to preserve debuggability and using the ${CMAKE_STRIP} variable instead of a hardcoded command to ensure toolchain consistency.
AustinBenoit
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the size of the built Apple and Linux libraries by stripping unnecessary symbols from them.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/25084056378
Type of Change
Place an
xthe applicable box: