Feat: enable setting the auth emulator in code#1486
Open
AustinBenoit wants to merge 5 commits into
Open
Conversation
…and configure dynamically for automated tests in UIHandlerAutomated.cs
… template in UIHandler.cs
Contributor
There was a problem hiding this comment.
Code Review
This pull request exposes the UseEmulator method in the SWIG interface for the Auth SDK and adds commented-out usage examples in the test app. The reviewer identified a potential crash if a null pointer is passed as the host parameter and suggested adding a null check to handle this safely.
Comment on lines
+488
to
+490
| void UseEmulator(const char* host, int port) { | ||
| self->UseEmulator(host, port); | ||
| } |
Contributor
There was a problem hiding this comment.
If host is nullptr (for example, if a C# user passes null to UseEmulator), passing it directly to self->UseEmulator will cause undefined behavior or a crash when constructing std::string implicitly from a null pointer on the C++ side.
We should add a null check for host to prevent potential crashes and ensure defensive programming.
void UseEmulator(const char* host, int port) {
if (host != nullptr) {
self->UseEmulator(host, port);
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feat: enable setting the auth emulator in code
Testing
Ran locally with emulator in desktop.
Type of Change
Place an
xthe applicable box: