Skip to content

Commit b8526a9

Browse files
committed
ci(e2e): harden workflow triggers and browser cache
1 parent 7d66b8e commit b8526a9

2 files changed

Lines changed: 34 additions & 4 deletions

File tree

.github/workflows/e2e.yaml

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,23 @@ on:
44
push:
55
branches:
66
- main
7+
paths:
8+
- 'packages/**'
9+
- 'examples/**'
10+
- 'e2e/**'
11+
- '.github/workflows/e2e.yaml'
12+
- 'package.json'
13+
- 'pnpm-lock.yaml'
14+
- 'pnpm-workspace.yaml'
715
pull_request:
16+
paths:
17+
- 'packages/**'
18+
- 'examples/**'
19+
- 'e2e/**'
20+
- '.github/workflows/e2e.yaml'
21+
- 'package.json'
22+
- 'pnpm-lock.yaml'
23+
- 'pnpm-workspace.yaml'
824

925
permissions:
1026
contents: read
@@ -30,6 +46,20 @@ jobs:
3046
- name: Install dependencies
3147
run: pnpm install
3248

49+
- name: Resolve Playwright version
50+
id: playwright-version
51+
run: |
52+
version="$(pnpm --filter=e2e exec node -p "require('@playwright/test/package.json').version")"
53+
echo "playwright-version=${version}" >> "$GITHUB_OUTPUT"
54+
55+
- name: Cache Playwright browsers
56+
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
57+
with:
58+
path: ~/.cache/ms-playwright
59+
key: playwright-${{ runner.os }}-${{ steps.playwright-version.outputs.playwright-version }}
60+
restore-keys: |
61+
playwright-${{ runner.os }}-
62+
3363
- name: Install Firebase CLI
3464
run: npm i -g firebase-tools@14.15.2
3565

@@ -49,5 +79,5 @@ jobs:
4979
- name: Install Playwright browsers
5080
run: pnpm --filter=e2e exec playwright install --with-deps chromium
5181

52-
- name: Run UI e2e smoke (react, shadcn, nextjs, nextjs-ssr)
82+
- name: Run UI e2e smoke
5383
run: pnpm test:e2e

developer-docs/work-queues/playwright-e2e-smoke.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,9 @@ Update immediately after each step closes a gate. All items start `open` / `impl
205205
| 2b | 2b.2 fix NG0201 bootstrap | closed | closed | closed | test(angular): e2e test for angular example ||| fixed via peer-resolved injected workspace dependency + provider factory cleanup. |
206206
| 2b | 2b.3 wire angular into serial runner | closed | closed | closed | test(angular): e2e test for angular example ||| `pnpm test:e2e` = five UI examples, green locally. |
207207
| 2b | 2b.4 add angular to CI + verify | closed | closed | closed | test(angular): e2e test for angular example ||| workflow already runs `pnpm test:e2e`; next PR run verifies in GHA. |
208-
| 3 | 3.1 e2e workflow browser cache | open | open | open | | implementation | area-focused | blocked on 2.5 CI baseline |
209-
| 3 | 3.2 broad path triggers | open | open | open || implementation | unit-focused | |
210-
| 4 | 4.1 custom-auth-server HTTP smoke (:4001) | open | open | open || implementation | area-focused | |
208+
| 3 | 3.1 e2e workflow browser cache | closed | closed | closed | ci(e2e): harden workflow triggers and browser cache | | | browser cache keyed by resolved `@playwright/test` version; static review green. |
209+
| 3 | 3.2 broad path triggers | closed | closed | closed | ci(e2e): harden workflow triggers and browser cache | | | AD-7 paths added for packages/examples/e2e/workflow/root manifests. |
210+
| 4 | 4.1 custom-auth-server HTTP smoke (:4001) | open | open | open || implementation | area-focused | **Next pickup.** |
211211
| 5 | 5.1 VITE_E2E skip oneTapSignIn | open | open | open || implementation | unit-focused | only if flaky |
212212
| 5 | 5.2 NEXT_PUBLIC_E2E skip autoAnonymousLogin | open | open | open || implementation | unit-focused | only if flaky |
213213
| 6 | 6.1 align example deps | open | open | open || implementation | area-focused | |

0 commit comments

Comments
 (0)