feat(vertexai): Add repetition penalties to GenerationConfig#17234
Merged
cynthiajoan merged 7 commits intofirebase:mainfrom Mar 28, 2025
Merged
feat(vertexai): Add repetition penalties to GenerationConfig#17234cynthiajoan merged 7 commits intofirebase:mainfrom
cynthiajoan merged 7 commits intofirebase:mainfrom
Conversation
This commit adds two new instance variables, and , to the class. These variables control the likelihood of repeating words or phrases in the generated text. The implementation is based on the Swift SDK and includes corresponding documentation. Note: Unable to run tests due to unavailable test execution environment.
Contributor
Author
|
cc: @cynthiajoan This isn't urgent but hopefully this will provide most or all of the code changes necessary for adding |
cynthiajoan
approved these changes
Mar 26, 2025
cynthiajoan
requested changes
Mar 26, 2025
Collaborator
cynthiajoan
left a comment
There was a problem hiding this comment.
Actually, we should put them into the base configuration class so it can share with LiveConfig
natebosch
approved these changes
Mar 26, 2025
cynthiajoan
reviewed
Mar 27, 2025
Both `presencePenalty` and `frequencyPenalty` have now been added to: https://firebase.google.com/docs/vertex-ai/model-parameters?platform=flutter#configure-model-parameters-gemini
cynthiajoan
approved these changes
Mar 27, 2025
rachelsaunders
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added support for repetition penalties (
presencePenaltyandfrequencyPenalty) inGenerationConfigin the Vertex AI in Firebase SDK. This brings it in alignment with the other SDKs.AI Prompt
The initial commit was generated with Jules using the following prompt:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?