feat(fdc): Hardening #18173
Conversation
aashishpatil-g
commented
Apr 6, 2026
aashishpatil-g
commented
- Handle QueryRef cancellations
- Additional debug statements
- Fix: only create one multicast controller per QueryRef
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
* debug logging and hardering * Hardening: ensure only one multicast stream controller is created in a ref * Handle cancellations * Formatting fix
* feat(fdc): Happy Path Implementation (#18151) * Initial Commit * Fix formatting and analyzer warnings * Fix tests and licenses * Denver feedback: var initialization best practice * sorted keys for id generation * Fix analyze info messages * feat(fdc): Handle disconnects and reconnects (#18157) * Handle disconnects and reconnects * Address gemini review comments * Reconnection logic * Fixes to reconnect on startup * Fix to decode binary data from server * Handle gemini feedback * Update rest_transport mocks with new windows provider sig * feat(fdc): Hardening (#18173) * debug logging and hardering * Hardening: ensure only one multicast stream controller is created in a ref * Handle cancellations * Formatting fix * Cynthia feedback (final, ...) * Gemini feedback: checkTransport single instancing. * Gemini feedback: cancel and nullify authSubscription in disconnect * Reverting authSubscription nullifying This affects reconnects. Taking tech debt instead. * Handle low priority gemini feedback * Gemini feedback: optimized operation id creation initialized as a lazy var that is used everywhere instead of computing always * Remove _queryId and use the computed operationId * Cynthia feedback on sending empty message to server * Remove grpc transport since its no longer used. * Update tests to incorporate operationId * Remove authToken appCheckToken fields. * Remove metadata file
2 participants
