Skip to content

chore(fdc): Integration Tests for Websockets#18216

Merged
Lyokone merged 3 commits intomainfrom
ap/fdcIntegrationTests
Apr 22, 2026
Merged

chore(fdc): Integration Tests for Websockets#18216
Lyokone merged 3 commits intomainfrom
ap/fdcIntegrationTests

Conversation

@aashishpatil-g
Copy link
Copy Markdown
Contributor

@aashishpatil-g aashishpatil-g commented Apr 21, 2026

  • Integration tests for Websockets and streaming.
  • Regenerated code for example project used for testing.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@aashishpatil-g aashishpatil-g changed the title Integration Tests for Websockets chore(fdc): Integration Tests for Websockets Apr 21, 2026
@aashishpatil-g
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds WebSocket E2E tests, updates macOS configuration, and enhances generated Dart classes with immutability and equality implementations. Feedback highlights the need to avoid accessing internal properties via dynamic in tests to prevent brittleness. Additionally, the reviewer noted violations of the 20-line function limit in the new tests and identified naming convention inconsistencies and syntax errors within the documentation.

Comment thread packages/firebase_data_connect/firebase_data_connect/example/pubspec.yaml Outdated
@Lyokone Lyokone merged commit 865f03b into main Apr 22, 2026
26 of 28 checks passed
@Lyokone Lyokone deleted the ap/fdcIntegrationTests branch April 22, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants