feat(core): Add Auth and AppCheck as App's registered service.#18237
feat(core): Add Auth and AppCheck as App's registered service.#18237cynthiajoan wants to merge 10 commits intomainfrom
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a service registry mechanism within FirebaseApp to allow for auto-injection of services like FirebaseAppCheck and FirebaseAuth. It updates the FirebaseAI initialization logic to leverage this registry, simplifying instance creation across the example app and tests. I have included a suggestion to improve the conciseness of the getService method using idiomatic Dart syntax, and I recommend ensuring that the registry is cleaned up when an app is deleted to prevent potential memory leaks.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request implements a service registry within FirebaseApp, enabling automatic resolution of Firebase services. FirebaseAuth and FirebaseAppCheck now register themselves upon instantiation, allowing FirebaseAI to automatically retrieve these dependencies and deprecating the need for manual injection in its factory methods. Feedback was provided to simplify the getService method using null-aware operators to improve code conciseness.
| T? getService<T extends FirebaseService>() { | ||
| final registry = _registries[name]; | ||
| if (registry != null) { | ||
| return registry[T] as T?; | ||
| } | ||
| return null; | ||
| } |
There was a problem hiding this comment.
The getService method can be simplified using Dart's null-aware operators for better conciseness and readability.
T? getService<T extends FirebaseService>() {
return _registries[name]?[T] as T?;
}…alized after firebaseai init and before api call
paulb777
left a comment
paulb777
left a comment
There was a problem hiding this comment.
LGTM - should get a Dart knowledgeable reviewer if possible. Thanks!
2 participants
Description
This could enable firebase_ai to use Auth and AppCheck without explicit pass it into the ai service constructor.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?