Skip to content

fix(database): fix a regression with database localEvents handling#18257

Merged
Lyokone merged 2 commits intomainfrom
fix/native-bridge-database
May 7, 2026
Merged

fix(database): fix a regression with database localEvents handling#18257
Lyokone merged 2 commits intomainfrom
fix/native-bridge-database

Conversation

@Lyokone
Copy link
Copy Markdown
Contributor

@Lyokone Lyokone commented May 6, 2026

Description

Fixes runTransaction(applyLocally: false) in firebase_database on Android and iOS. The Pigeon rewrite carried the applyLocally value through Dart, but the native transaction calls ignored it and used the default local-event behavior; this now forwards the flag to the native SDK transaction APIs and adds integration coverage for the suppressed local-event path.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


expect(events, hasLength(1));
} finally {
await database.goOnline();
Copy link
Copy Markdown

@cabljac cabljac May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this reconnects to firebase? is this required here? I may be missing something

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running applyLocally false, it's like you "disconnect" from realtime database, so you need to go back online after the test for the following to run properly :)

Copy link
Copy Markdown

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one small comment/nit

@Lyokone Lyokone merged commit 40fd290 into main May 7, 2026
35 checks passed
@Lyokone Lyokone deleted the fix/native-bridge-database branch May 7, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_database]: runTransaction(applyLocally: false) no longer suppresses local-cache emit on 12.1.0+ (regression from #17686)

3 participants