fix(database): fix a regression with database localEvents handling#18257
fix(database): fix a regression with database localEvents handling#18257
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
|
||
| expect(events, hasLength(1)); | ||
| } finally { | ||
| await database.goOnline(); |
There was a problem hiding this comment.
nit: this reconnects to firebase? is this required here? I may be missing something
There was a problem hiding this comment.
When running applyLocally false, it's like you "disconnect" from realtime database, so you need to go back online after the test for the following to run properly :)
Description
Fixes
runTransaction(applyLocally: false)infirebase_databaseon Android and iOS. The Pigeon rewrite carried theapplyLocallyvalue through Dart, but the native transaction calls ignored it and used the default local-event behavior; this now forwards the flag to the native SDK transaction APIs and adds integration coverage for the suppressed local-event path.Related Issues
Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change