refactor: address PR review feedback

* Link from root README.md
* Fix clone directory path in Dart sample README
* Fix sample run.app url format in README
* Fix sample run.app url format in sample documentation blocks
* Return 400 Bad Request on invalid JSON
* Apply a default format string of "MMMM d yyyy, h:mm:ss a" prior to the return block

Co-authored-by: jhuleatt <3759507+jhuleatt@users.noreply.github.com>

Author: google-labs-jules[bot]

Dart/quickstarts/https-time-server/README.md

@@ -16,7 +16,7 @@ Further reading:
 
 ### 1. Clone this repo
 
-Clone or download this repo and open the `quickstarts/time-server` directory.
+Clone or download this repo and open the `Dart/quickstarts/https-time-server` directory.
 
 
 ### 2. Create a Firebase project and configure the quickstart
@@ -67,21 +67,21 @@ Alteratively, you can call `firebase emulators:start` to test the functions on t
 
 After deploying the function, check the CLI's output to see the URL for your function.
 
-It will look something like: `https://<function-name>-<random-hash>-<region>.a.run.app`
+It will look something like: `https://<function-name>-<random-hash>.<region>.run.app`
 
 You can also send the format in the request body. For instance using cURL in the command line:
 
 ```bash
 curl -H 'Content-Type: application/json' /
      -d '{"format": "MMMM d yyyy, h:mm:ss a"}' /
-     <function url>/date
+     <function url>
 ```
 Formatted dates should be displayed.
 
 We are responding with a 403 error in case of PUT requests:
 
 ```bash
-curl -X PUT -d '{"format": "MMMM d yyyy, h:mm:ss a"}' <function-url>/date
+curl -X PUT -d '{"format": "MMMM d yyyy, h:mm:ss a"}' <function-url>
 ```
 
 

Dart/quickstarts/https-time-server/bin/server.dart

@@ -32,11 +32,11 @@ import 'package:intl/intl.dart';
 ///
 /// Example format: "MMMM d yyyy, h:mm:ss a".
 /// Example request using URL query parameters:
-///   https://us-central1-<project-id>.cloudfunctions.net/date?format=MMMM%20d%20yyyy%2C%20h%3Amm%3Ass%20a
+///   https://date-<random-hash>.<region>.run.app?format=MMMM%20d%20yyyy%2C%20h%3Amm%3Ass%20a
 /// Example request using request body with cURL:
 ///   curl -H 'Content-Type: application/json' /
 ///        -d '{"format": "MMMM d yyyy, h:mm:ss a"}' /
-///        https://us-central1-<project-id>.cloudfunctions.net/date
+///        https://date-<random-hash>.<region>.run.app
 void main(List<String> args) async {
   await fireUp(args, (firebase) {
     // [START dartHttpTrigger]
@@ -65,15 +65,16 @@ void main(List<String> args) async {
             format = body['format'] as String?;
           }
         } catch (e) {
-          // Ignore JSON parsing errors
+          return Response.badRequest(body: 'invalid JSON');
         }
         // [END dartHttpReadBodyParam]
       }
 
+      // Set a default format if none was provided
+      format ??= 'MMMM d yyyy, h:mm:ss a';
+
       // [START dartHttpSendResponse]
-      final formattedDate = format != null
-          ? DateFormat(format).format(DateTime.now())
-          : DateTime.now().toString();
+      final formattedDate = DateFormat(format).format(DateTime.now());
       print('Sending formatted date: $formattedDate');
       return Response.ok(formattedDate);
       // [END dartHttpSendResponse]

README.md

@@ -37,6 +37,7 @@ This quickstart sample demonstrates using **Cloud Functions** triggered by **Fir
 
 ### HTTPS trigger quickstart: Time Server
 
+- [Dart](/Dart/quickstarts/https-time-server/)
 - [Node 2nd gen](/Node/quickstarts/https-time-server/)
 - [Python](/Python/quickstarts/https-time-server/)
 - [Node 1st gen](/Node-1st-gen/quickstarts/https-time-server/)