Add beforeSendEmail and beforeSendSms blocking functions samples#1253
Merged
jhuleatt merged 5 commits intofirebase:mainfrom Apr 6, 2026
Merged
Add beforeSendEmail and beforeSendSms blocking functions samples#1253jhuleatt merged 5 commits intofirebase:mainfrom
jhuleatt merged 5 commits intofirebase:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new Firebase Auth Blocking functions for both Node.js and Python quickstarts. It adds beforeEmailSent and beforeSmsSent triggers to block email sending to non-acme.com domains and SMS sending to non-US phone numbers. The review comments suggest minor readability improvements in the Node.js functions by explicitly checking for the existence of user.email and user.phoneNumber before calling string methods, even though optional chaining provides functional safety.
macastelaz
force-pushed
the
add-before-send-samples
branch
2 times, most recently
from
b71c7de to
d41d3a8
Compare
macastelaz
force-pushed
the
add-before-send-samples
branch
from
d41d3a8 to
b87ceec
Compare
jhuleatt
approved these changes
Apr 3, 2026
Collaborator
jhuleatt
left a comment
jhuleatt
left a comment
There was a problem hiding this comment.
Thanks @macastelaz! I added some refinement suggestions but overall LGTM
Refactor error handling to improve readability by formatting error messages across multiple lines.
jhuleatt
reviewed
Apr 6, 2026
jhuleatt
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supplement samples in Node and Python to include examples of beforeSendEmail and beforeSendSms