Skip to content

Add pipeline snippets for web and nodejs#404

Open
morganchen12 wants to merge 32 commits intomasterfrom
mc/pipelines
Open

Add pipeline snippets for web and nodejs#404
morganchen12 wants to merge 32 commits intomasterfrom
mc/pipelines

Conversation

@morganchen12
Copy link
Copy Markdown
Contributor

No description provided.

@morganchen12 morganchen12 changed the title Mc/pipelines Add pipeline snippets Oct 29, 2025
Comment thread firestore-next/package.json Outdated
Copy link
Copy Markdown

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not finish the review, but here is some high level feedback that needs to be addressed. Some across all samples.

Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/package.json Outdated
Copy link
Copy Markdown

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comments. There are a few remaining errors and a few nits I commented on.

Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js
Comment thread firestore-next/test.firestore.js Outdated
Comment thread firestore-next/test.firestore.js Outdated
}

async function strSplitFunction() {
// not yet supported until GA
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is supported now

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in SDKs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find this method after updating both the web and iOS SDKs. I haven't checked the other ones yet.

Comment thread firestore-next/test.firestore.js Outdated
markarndt and others added 4 commits November 6, 2025 14:56
Add missing START/END for ends_with
* add admin snippets temporarily

* write node snippets

* run snippets
@morganchen12 morganchen12 changed the title Add pipeline snippets Add pipeline snippets for web and nodejs Nov 7, 2025
Comment thread firestore-next/test.firestore.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants