fix: reject non-array needs with clear error

[firecow]

Summary

• needs: build (scalar string instead of a list) crashed with TypeError: Attempted to assign to readonly property in needsEach because Object.entries iterated the string's characters and assignment to string indices is read-only.
• Now asserts needs is an array up front, matching the upstream GitLab schema (top-level needs is "type": "array").

Test plan

• bunx vitest run tests/test-cases/needs-not-array/ passes
• Existing needs-* tests still pass

---

Summary by cubic

Reject non-array job needs with a clear error. Prevents a crash when a string is used and aligns with GitLab’s array schema.

• Bug Fixes
  • Assert array type in needsEach to replace the prior TypeError with a helpful message.
  • Add integration test case to verify rejection and error text.

^{Written for commit 4739609. Summary will update on new commits. Review in cubic}

[cubic-dev-ai]

1 issue found across 3 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud