fix: Preserve kernel argument ordering#487
Open
DZDomi wants to merge 4 commits intofirecracker-microvm:mainfrom
Open
fix: Preserve kernel argument ordering#487DZDomi wants to merge 4 commits intofirecracker-microvm:mainfrom
DZDomi wants to merge 4 commits intofirecracker-microvm:mainfrom
Conversation
Signed-off-by: Dominik De Zordo <dominik@trality.com>
Signed-off-by: Dominik De Zordo <dominik@trality.com>
Signed-off-by: Dominik De Zordo <dominik@trality.com>
Signed-off-by: Dominik De Zordo <dominik@trality.com>
022e877 to
4f469e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the SDK uses a map for storing the kernel arguments. This map will then be serialised back into a string before it is passed to the firecracker process. Since the iteration of a map in go is random and not deterministic the kernel params will be given in any order, which can result in a failure in the following case:
When passing init arguments to the kernel with the
--flag the SDK will save it correctly in the map, but after turning it back into a string the order of the arguments is not correct.As an example with the following arguments:
Before the fix this could result in:
Which would not pass these arguments into the init or even worse prevents the VM from starting.
After the fix the order of the arguments is always preserved and will be given like this to the kernel:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.