Skip to content

Commit 8b55c86

Browse files
committed
vmm: Remove long unnecessary comment in register_msi()
The comment inside register_msi() is unnecessary. The devid field name is descriptive enough and the fact that we currently present a single PCIe segment is irrelevant. Remove it. Signed-off-by: Ilias Stamatis <ilstam@amazon.com>
1 parent 5303444 commit 8b55c86

1 file changed

Lines changed: 0 additions & 13 deletions

File tree

src/vmm/src/vstate/vm.rs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -443,19 +443,6 @@ impl Vm {
443443
entry.u.msi.data = config.data;
444444

445445
if self.common.fd.check_extension(kvm_ioctls::Cap::MsiDevid) {
446-
// According to KVM documentation:
447-
// https://docs.kernel.org/virt/kvm/api.html#kvm-set-gsi-routing
448-
//
449-
// if the capability is set, we need to set the flag and provide a valid unique device
450-
// ID. "For PCI, this is usually a BDF identifier in the lower 16 bits".
451-
//
452-
// The layout of `config.devid` is:
453-
//
454-
// |---- 16 bits ----|-- 8 bits --|-- 5 bits --|-- 3 bits --|
455-
// | segment | bus | device | function |
456-
//
457-
// For the time being, we are using a single PCI segment and a single bus per segment
458-
// so just passing config.devid should be fine.
459446
entry.flags = KVM_MSI_VALID_DEVID;
460447
entry.u.msi.__bindgen_anon_1.devid = config.devid.into();
461448
}

0 commit comments

Comments
 (0)