Skip to content

Commit a19e57b

Browse files
pavitrabhallaclaude
andcommitted
fix(jailer): pin landlock to 0.4.4 and fix markdown style
- Pin `landlock` dependency to exact patch version "0.4.4" per CI requirement (was "0.4"). - Run `mdformat .` to fix markdown style failures in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Pavitra Bhalla <pavitra@superserve.ai>
1 parent 1e5bc98 commit a19e57b

9 files changed

Lines changed: 21 additions & 27 deletions

File tree

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
---
2-
name: Bug report
3-
about: Create a report to help us improve
4-
title: '[Bug] Title'
5-
labels: 'Quality: Bug'
6-
assignees: ''
7-
---
1+
______________________________________________________________________
2+
3+
## name: Bug report about: Create a report to help us improve title: '[Bug] Title' labels: 'Quality: Bug' assignees: ''
84

95
# Describe the bug
106

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
---
2-
name: Feature request
3-
about: Suggest an idea for this project
4-
title: '[Feature Request] Title'
5-
labels: ''
6-
assignees: ''
7-
---
1+
______________________________________________________________________
2+
3+
## name: Feature request about: Suggest an idea for this project title: '[Feature Request] Title' labels: '' assignees: ''
84

95
# Feature Request
106

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,19 @@ and this project adheres to
2121
support for Vsock Unix domain socket path overriding on snapshot restore. More
2222
information can be found in the
2323
[docs](docs/vsock.md/#unix-domain-socket-renaming).
24+
2425
- [#5824](https://github.com/firecracker-microvm/firecracker/pull/5824): Add
2526
optional rate limiting to serial console output, configurable via the
2627
`rate_limiter` field on `PUT /serial`. A new metric is exposed under `uart`:
2728
`rate_limiter_dropped_bytes`.
29+
2830
- [#5799](https://github.com/firecracker-microvm/firecracker/pull/5799): Add
2931
per-callsite rate limiting for error, warn, and info level log messages. Each
3032
callsite independently allows up to 10 messages per 5-second window. When
3133
logging resumes after suppression, a warn-level summary reports the count of
3234
suppressed messages. A new `rate_limited_log_count` metric tracks the total
3335
number of suppressed messages.
36+
3437
- [#5789](https://github.com/firecracker-microvm/firecracker/pull/5789): Add
3538
rate-limiter support to virtio-pmem device to allow control over I/O bandwidth
3639
generated by the FLUSH requests from the guest.

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,5 +225,5 @@ message automatically.
225225

226226
Forgot to add DCO to a commit? Amend it with `git commit --amend -s`.
227227

228-
[^1]: Performance improvements in non-hot paths are unlikely to be considered
229-
valuable.
228+
\[^1\]: Performance improvements in non-hot paths are unlikely to be considered
229+
valuable.

SPECIFICATION.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,12 @@ on the following:
5959
are full will be lost. Any such events will be signaled through the
6060
`lost-logs` and `lost-metrics` counters.
6161

62-
[^1]: CPU ms are actual ms of a user space thread's on-CPU runtime; useful for
63-
getting consistent measurements for some performance metrics.
62+
\[^1\]: CPU ms are actual ms of a user space thread's on-CPU runtime; useful for
63+
getting consistent measurements for some performance metrics.
6464

65-
[^2]: No logs are currently produced in the span of time between the `jailer`
66-
process start-up and the logging system initialization in the
67-
`firecracker` process.
65+
\[^2\]: No logs are currently produced in the span of time between the `jailer`
66+
process start-up and the logging system initialization in the `firecracker`
67+
process.
6868

6969
[1]: https://aws.amazon.com/ec2/instance-types/m5/
7070
[2]: https://aws.amazon.com/ec2/instance-types/m6/

docs/jailer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ Here is an example on how to set multiple resource limits using this argument:
106106
escapes the `pivot_root` chroot via a kernel exploit, Landlock (enforced by a
107107
separate LSM path) independently prevents access to files outside the jail.
108108
The flag operates in best-effort mode — on kernels without Landlock support
109-
(< 5.13) it has no effect.
109+
(\< 5.13) it has no effect.
110110
- The jailer adheres to the "end of command options" convention, meaning all
111111
parameters specified after `--` are forwarded to Firecracker. For example,
112112
this can be paired with the `--config-file` Firecracker argument to specify a

docs/memory-hotplug.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,5 +333,4 @@ driver may be able to trick the backend to access unplugged memory. This is not
333333
possible in Firecracker itself as unplugged memory slots are `mprotect`-ed.
334334

335335
[^uffd]: snapshotting/handling-page-faults-on-snapshot-resume.md#userfaultfd
336-
337336
[^vhost-user]: api_requests/block-vhost-user.md

docs/prod-host-setup.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -461,6 +461,6 @@ sudo modprobe $KVM_VENDOR_MOD
461461
To validate that the change took effect, the file
462462
`/sys/module/kvm/parameters/nx_huge_pages` should say `never`.
463463

464-
[^1]: Look for `GRUB_CMDLINE_LINUX` in file `/etc/default/grub` in RPM-based
465-
systems, and
466-
[this doc for Ubuntu](https://wiki.ubuntu.com/Kernel/KernelBootParameters).
464+
\[^1\]: Look for `GRUB_CMDLINE_LINUX` in file `/etc/default/grub` in RPM-based
465+
systems, and
466+
[this doc for Ubuntu](https://wiki.ubuntu.com/Kernel/KernelBootParameters).

src/jailer/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ bench = false
1515
tracing = ["log-instrument", "utils/tracing"]
1616

1717
[dependencies]
18-
landlock = "0.4"
18+
landlock = "0.4.4"
1919
libc = "0.2.186"
2020
log-instrument = { path = "../log-instrument", optional = true }
2121
regex = { version = "1.12.3", default-features = false, features = ["std"] }

0 commit comments

Comments
 (0)