Skip to content

Commit ac42726

Browse files
marco-marangoniShadowCurse
authored andcommitted
Re-enable most performance tests
With #5955 merged, there should be less false positives in the A/B performance tests. This commits re-enables most performance tests, and only leaves ignored tests for which we don't want to receive tickets at all. Signed-off-by: Marco Marangoni <mamarang@amazon.com>
1 parent 8c4bc5a commit ac42726

1 file changed

Lines changed: 1 addition & 50 deletions

File tree

tools/ab_test.py

Lines changed: 1 addition & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -115,62 +115,13 @@ def format_with_reduced_unit(value, unit):
115115
return f"{reduced_value:.2f}{formatted_unit}"
116116

117117

118-
# Performance tests that are known to be unstable and exhibit variances of up to 60% of the mean
118+
# Performance tests that we don't want to alarm on.
119119
IGNORED = [
120-
# Network throughput on m6a.metal
121-
{"instance": "m6a.metal", "performance_test": "test_network_tcp_throughput"},
122-
# Network throughput on m7a.metal
123-
{"instance": "m7a.metal-48xl", "performance_test": "test_network_tcp_throughput"},
124-
# vsock throughput on m7a.metal
125-
{
126-
"instance": "m7a.metal-48xl",
127-
"performance_test": "test_vsock_throughput",
128-
"mode": "g2h",
129-
},
130-
# Network latency on m6a.metal / m7a.metal
131-
*[
132-
{"instance": instance, "performance_test": "test_network_latency"}
133-
for instance in ["m6a.metal", "m7a.metal-48xl"]
134-
],
135-
# Network latencies on m8i.metal-{48,96}xl w/ 5.10 host
136-
*[
137-
{
138-
"instance": instance,
139-
"performance_test": "test_network_latency",
140-
"host_kernel": "linux-5.10",
141-
}
142-
for instance in ["m8i.metal-48xl", "m8i.metal-96xl"]
143-
],
144-
# Network latencies on m5n.metal w/ al2 host
145-
{
146-
"instance": "m5n.metal",
147-
"performance_test": "test_network_latency",
148-
"host_kernel": "linux-5.10",
149-
},
150-
# Network latencies on m8g
151-
*[
152-
{"instance": instance, "performance_test": "test_network_latency"}
153-
for instance in ["m8g.metal-24xl", "m8g.metal-48xl"]
154-
],
155-
# MMDS metrics on m8i, m7g and m8g
156-
*[
157-
{"instance": instance, "performance_test": "test_mmds_performance"}
158-
for instance in [
159-
"m8i.metal-48xl",
160-
"m8i.metal-96xl",
161-
"m7g.metal",
162-
"m8g.metal-24xl",
163-
"m8g.metal-48xl",
164-
]
165-
],
166120
# block latencies if guest uses async request submission
167121
{"fio_engine": "libaio", "metric": "clat_read"},
168122
{"fio_engine": "libaio", "metric": "clat_write"},
169123
# boot time metrics
170124
{"performance_test": "test_boottime", "metric": "resume_time"},
171-
# block throughput on m8g
172-
{"fio_engine": "libaio", "vcpus": "2", "instance": "m8g.metal-24xl"},
173-
{"fio_engine": "libaio", "vcpus": "2", "instance": "m8g.metal-48xl"},
174125
# memory hotplug metrics: ignore api_time and fc_time metrics, keeping only total_time.
175126
*[
176127
{

0 commit comments

Comments
 (0)