Skip to content

Commit ac7510c

Browse files
not4sShadowCurse
authored andcommitted
test: skip flaky hotplug tests on x86_64 5.10 hosts
test_virtio_mem_hotplug_hotunplug and test_memory_hotplug_latency intermittently fail on x86_64 5.10 hosts, where the GET /hotplug/memory API call exceeds the maximum duration assertion. Skip both there until the latency is investigated. Signed-off-by: Jay Chung <jaehoc@amazon.com>
1 parent 7503f25 commit ac7510c

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

tests/integration_tests/performance/test_hotplug_memory.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
run on an ag=1 host due to the use of HugePages.
99
"""
1010

11+
import platform
12+
1113
import pytest
1214
from tenacity import Retrying, retry_if_exception_type, stop_after_delay, wait_fixed
1315

@@ -252,6 +254,11 @@ def check_hotunplug(uvm, requested_size_mib):
252254
assert rss_after < rss_before, "RSS didn't decrease"
253255

254256

257+
# TODO: remove this once the hotplug latency on 5.10 hosts is fixed
258+
@pytest.mark.skipif(
259+
platform.machine() == "x86_64" and global_props.host_linux_version_tpl == (5, 10),
260+
reason="GET /hotplug/memory intermittently exceeds the duration threshold on x86_64 5.10 hosts",
261+
)
255262
def test_virtio_mem_hotplug_hotunplug(uvm_any_memhp):
256263
"""
257264
Check that memory can be hotplugged into the VM.
@@ -456,6 +463,11 @@ def timed_memory_hotplug(uvm, size, metrics, metric_prefix, fc_metric_name):
456463
)
457464

458465

466+
# TODO: remove this once the hotplug latency on 5.10 hosts is fixed
467+
@pytest.mark.skipif(
468+
platform.machine() == "x86_64" and global_props.host_linux_version_tpl == (5, 10),
469+
reason="GET /hotplug/memory intermittently exceeds the duration threshold on x86_64 5.10 hosts",
470+
)
459471
@pytest.mark.nonci
460472
@pytest.mark.parametrize(
461473
"hotplug_size",

0 commit comments

Comments
 (0)