fix(snapshot): handle errors in PCI cfg on snap restore#5841
Merged
JamesC1305 merged 3 commits intoApr 23, 2026
Conversation
There are a few places in the PCI transport snapshot restore code where Vecs (serialised in snapshot) are converted to fixed-size arrays (used at runtime). If a bad snapshot was supplied as input with wrong-sized vecs, Firecracker would panic. Add some error handling to prevent such panics. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5841 +/- ##
=======================================
Coverage 82.88% 82.88%
=======================================
Files 276 276
Lines 29708 29725 +17
=======================================
+ Hits 24623 24638 +15
- Misses 5085 5087 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesC1305
added
the
Status: Awaiting review
ShadowCurse
reviewed
Apr 16, 2026
zulinx86
previously approved these changes
Apr 16, 2026
JamesC1305
force-pushed
the
fix_snapshot_pci_panic
branch
from
c277037 to
06439aa
Compare
Contributor
Author
|
Changed to using serde-big-array rather than converting between vec and array. |
JamesC1305
changed the title
ShadowCurse
previously approved these changes
Apr 17, 2026
zulinx86
reviewed
Apr 17, 2026
zulinx86
previously approved these changes
Apr 17, 2026
JamesC1305
force-pushed
the
fix_snapshot_pci_panic
branch
4 times, most recently
from
00013fd to
c277037
Compare
ShadowCurse
approved these changes
Apr 23, 2026
zulinx86
approved these changes
Apr 23, 2026
JamesC1305
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle errors in PCI configuration code on snapshot restore
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.