fix: snapshot: disallow snapshots with vhost-user devices#5845
Merged
ShadowCurse merged 1 commit intoApr 23, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5845 +/- ##
==========================================
+ Coverage 83.04% 83.06% +0.01%
==========================================
Files 276 276
Lines 29558 29583 +25
==========================================
+ Hits 24547 24573 +26
+ Misses 5011 5010 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
pre_snapshot_checks
branch
3 times, most recently
from
cc3f773 to
236328a
Compare
ShadowCurse
added
Status: Awaiting review
zulinx86
previously approved these changes
Apr 21, 2026
Manciukic
reviewed
Apr 22, 2026
ShadowCurse
force-pushed
the
pre_snapshot_checks
branch
4 times, most recently
from
e09f70e to
413525d
Compare
Previously we were incorrectly allow snapshots to be created even with vhost-user devices by simply ignoring them. Now we correctly return an error if we detect vhost-user devices. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
pre_snapshot_checks
branch
from
413525d to
02e15a2
Compare
zulinx86
approved these changes
Apr 22, 2026
Manciukic
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Previously we were incorrectly allow snapshots to be created even with vhost-user devices by simply ignoring them. Now we correctly return an error if we detect vhost-user devices.
Reason
Follow the docs: https://github.com/firecracker-microvm/firecracker/blob/main/docs/api_requests/block-vhost-user.md#snapshot-support
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.