feat: logger: decrease binary size#5849
Merged
ShadowCurse merged 1 commit intoApr 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5849 +/- ##
==========================================
- Coverage 83.07% 83.04% -0.04%
==========================================
Files 276 276
Lines 29546 29558 +12
==========================================
+ Hits 24546 24547 +1
- Misses 5000 5011 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesC1305
previously approved these changes
Apr 21, 2026
JackThomson2
previously approved these changes
Apr 21, 2026
b78bdad
b78bdad to
93cd705
Compare
JackThomson2
previously approved these changes
Apr 21, 2026
JamesC1305
previously approved these changes
Apr 21, 2026
zulinx86
reviewed
Apr 21, 2026
zulinx86
previously approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
4e44b94
93cd705 to
4e44b94
Compare
zulinx86
previously approved these changes
Apr 21, 2026
When new rate-limiter log macros were added, the binary size increased by ~150KiB. (mainly the .text section got bigger by ~105KiB) In order to partially mitigate this move duplicated checking logic into a `LogRateLimiter` type and mark that function with `inline(never)` This saves ~70KiB of .text section space. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
4e44b94 to
63d322d
Compare
JamesC1305
approved these changes
Apr 21, 2026
JackThomson2
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When new rate-limiter log macros were added, the binary size increased by ~150KiB. (mainly the .text section got bigger by ~105KiB)
In order to partially mitigate this move duplicated checking logic into a
LogRateLimitertype and mark that function withinline(never)This saves ~70KiB of .text section space.
Reason
Smaller binary
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.