Skip to content

Update CPU feature expectations for kernel 6.18#5851

Merged
JackThomson2 merged 2 commits into
firecracker-microvm:mainfrom
JackThomson2:feat/6_18_updates
Apr 23, 2026
Merged

Update CPU feature expectations for kernel 6.18#5851
JackThomson2 merged 2 commits into
firecracker-microvm:mainfrom
JackThomson2:feat/6_18_updates

Conversation

@JackThomson2
Copy link
Copy Markdown
Contributor

Amazon Linux 6.18 host kernel changes which CPU feature flags appear in /proc/cpuinfo. Update test_host_vs_guest_cpu_features expected host-only flag sets for each x86 CPU model when running on host kernel >= 6.18:

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.87%. Comparing base (3bd1eee) to head (ad263be).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5851   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files         276      276           
  Lines       29729    29729           
=======================================
  Hits        24638    24638           
  Misses       5091     5091           
Flag Coverage Δ
5.10-m5n.metal 83.17% <ø> (-0.01%) ⬇️
5.10-m6a.metal 82.50% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 79.78% <ø> (ø)
5.10-m6i.metal 83.17% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.50% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.78% <ø> (ø)
5.10-m7i.metal-24xl 83.14% <ø> (-0.01%) ⬇️
5.10-m7i.metal-48xl 83.14% <ø> (+<0.01%) ⬆️
5.10-m8g.metal-24xl 79.78% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 79.78% <ø> (ø)
5.10-m8i.metal-48xl 83.15% <ø> (ø)
5.10-m8i.metal-96xl 83.15% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.19% <ø> (ø)
6.1-m6a.metal 82.53% <ø> (-0.01%) ⬇️
6.1-m6g.metal 79.78% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 83.19% <ø> (ø)
6.1-m7a.metal-48xl 82.52% <ø> (ø)
6.1-m7g.metal 79.78% <ø> (+<0.01%) ⬆️
6.1-m7i.metal-24xl 83.21% <ø> (+<0.01%) ⬆️
6.1-m7i.metal-48xl 83.22% <ø> (+<0.01%) ⬆️
6.1-m8g.metal-24xl 79.78% <ø> (ø)
6.1-m8g.metal-48xl 79.78% <ø> (ø)
6.1-m8i.metal-48xl 83.21% <ø> (ø)
6.1-m8i.metal-96xl 83.21% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JackThomson2 JackThomson2 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Apr 22, 2026
Comment thread tests/integration_tests/functional/test_cpu_features_host_vs_guest.py Outdated
Comment thread tests/integration_tests/functional/test_cpu_features_host_vs_guest.py Outdated
@JackThomson2 JackThomson2 force-pushed the feat/6_18_updates branch 2 times, most recently from 7e7981a to f1177c7 Compare April 23, 2026 11:04
Comment thread tests/integration_tests/functional/test_cpu_features_host_vs_guest.py Outdated
Copy link
Copy Markdown
Contributor

@zulinx86 zulinx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the security-related bits and confirmed we're fine. Once you've updated the comment, please ping me to hit the approve button .

Amazon Linux 6.18 host kernel changes which CPU feature flags appear in
/proc/cpuinfo. Update test_host_vs_guest_cpu_features expected host-only
flag sets for each x86 CPU model when running on host kernel >= 6.18:

Signed-off-by: Jack Thomson <jackabt@amazon.com>
@JackThomson2 JackThomson2 enabled auto-merge (rebase) April 23, 2026 15:22
@JackThomson2 JackThomson2 merged commit 2440dbb into firecracker-microvm:main Apr 23, 2026
7 checks passed
@JackThomson2 JackThomson2 deleted the feat/6_18_updates branch April 23, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants