fix(tests): do not construct GuestDistro for docker-popular#5867
Merged
Manciukic merged 4 commits intoMay 12, 2026
Merged
Conversation
We saw failures on the docker popular tests because it was trying to create a GuestDistro instance but could not find a matching entry. In reality, we don't need this object for the docker popular tests, so just return None if it's not AL2023 or Ubuntu. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5867 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 277 277
Lines 29892 29892
=======================================
Hits 24753 24753
Misses 5139 5139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesC1305
added
Status: Awaiting author
JackThomson2
approved these changes
May 7, 2026
Manciukic
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We saw failures on the docker popular tests because it was trying to create a GuestDistro instance but could not find a matching entry. In reality, we don't need this object for the docker popular tests, so just return None if it's not AL2023 or Ubuntu.
Changes
GuestDistroReason
Docker popular tests were trying to construct
GuestDistrodataclasses for the test rootfs'.GuestDistroitself is never accessed during the tests, so we can just return None to fix this.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.