Skip to content

ci: disable test_virtio_mem_hotplug_hotunplug on x86/5.10#6008

Closed
ShadowCurse wants to merge 1 commit into
firecracker-microvm:mainfrom
ShadowCurse:disable_mem_hotunplug
Closed

ci: disable test_virtio_mem_hotplug_hotunplug on x86/5.10#6008
ShadowCurse wants to merge 1 commit into
firecracker-microvm:mainfrom
ShadowCurse:disable_mem_hotunplug

Conversation

@ShadowCurse

Copy link
Copy Markdown
Contributor

Changes

The test is failing all the time and blocks all pipelines. Disabling until the fix/rootcause is found.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.08%. Comparing base (7503f25) to head (9311c12).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6008   +/-   ##
=======================================
  Coverage   83.08%   83.08%           
=======================================
  Files         277      277           
  Lines       30201    30201           
=======================================
  Hits        25094    25094           
  Misses       5107     5107           
Flag Coverage Δ
5.10-m5n.metal 83.41% <ø> (-0.02%) ⬇️
5.10-m6a.metal 82.77% <ø> (ø)
5.10-m6g.metal 80.06% <ø> (ø)
5.10-m6i.metal 83.41% <ø> (-0.02%) ⬇️
5.10-m7a.metal-48xl 82.75% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.06% <ø> (ø)
5.10-m7i.metal-24xl 83.39% <ø> (ø)
5.10-m7i.metal-48xl 83.39% <ø> (-0.01%) ⬇️
5.10-m8g.metal-24xl 80.05% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 80.05% <ø> (-0.01%) ⬇️
5.10-m8i.metal-48xl 83.39% <ø> (-0.01%) ⬇️
5.10-m8i.metal-96xl 83.39% <ø> (ø)
6.1-m5n.metal 83.44% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.79% <ø> (ø)
6.1-m6g.metal 80.05% <ø> (-0.01%) ⬇️
6.1-m6i.metal 83.44% <ø> (ø)
6.1-m7a.metal-48xl 82.78% <ø> (ø)
6.1-m7g.metal 80.05% <ø> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.45% <ø> (ø)
6.1-m7i.metal-48xl 83.45% <ø> (-0.01%) ⬇️
6.1-m8g.metal-24xl 80.05% <ø> (-0.01%) ⬇️
6.1-m8g.metal-48xl 80.05% <ø> (-0.01%) ⬇️
6.1-m8i.metal-48xl 83.45% <ø> (-0.01%) ⬇️
6.1-m8i.metal-96xl 83.45% <ø> (ø)
6.18-m5n.metal 83.44% <ø> (-0.01%) ⬇️
6.18-m6a.metal 82.79% <ø> (ø)
6.18-m6g.metal 80.05% <ø> (-0.01%) ⬇️
6.18-m6i.metal 83.44% <ø> (ø)
6.18-m7a.metal-48xl 82.78% <ø> (-0.01%) ⬇️
6.18-m7g.metal 80.05% <ø> (-0.01%) ⬇️
6.18-m7i.metal-24xl 83.46% <ø> (+0.01%) ⬆️
6.18-m7i.metal-48xl 83.45% <ø> (ø)
6.18-m8g.metal-24xl 80.05% <ø> (-0.01%) ⬇️
6.18-m8g.metal-48xl 80.05% <ø> (-0.01%) ⬇️
6.18-m8i.metal-48xl 83.45% <ø> (-0.01%) ⬇️
6.18-m8i.metal-96xl 83.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The test is failing all the time and blocks all pipelines. Disabling
until the fix/rootcause is found.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
@ShadowCurse ShadowCurse force-pushed the disable_mem_hotunplug branch from 6bcb3e9 to 9311c12 Compare June 30, 2026 10:42
@ShadowCurse ShadowCurse marked this pull request as ready for review June 30, 2026 11:03
@ShadowCurse ShadowCurse self-assigned this Jun 30, 2026
@ShadowCurse ShadowCurse added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jun 30, 2026
@zulinx86

Copy link
Copy Markdown
Contributor

dup of #6007

@deRemo deRemo self-requested a review June 30, 2026 11:27
@not4s not4s added this pull request to the merge queue Jun 30, 2026
@not4s not4s removed this pull request from the merge queue due to a manual request Jun 30, 2026
@ShadowCurse ShadowCurse deleted the disable_mem_hotunplug branch June 30, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants