Switch off cargo audit#6009
Draft
ShadowCurse wants to merge 2 commits into
Draft
Conversation
`cargo-audit` goes through all crates in the Cargo.lock which includes crate which are pulled as transitive dependencies of some crates but not used in any of our binaries. Switching to `crago-deny` fixes this since it only checks crates which are a part of our dependencies tree for our binaries. Similar to `cargo-audit`, we need to install `cargo-deny` each time to avoid a possibility of it breaking if advisory database suddenly updates the format it uses. But for the sake of speed, we now install with `--debug` flag to install debug binary (install in this case means "compile"). This saves time and does not affect the result. `cargo-audit` is also used in other places (like license checks), but it is fine to only "install" it again here. Everywhere else we can use version installed in the docker image, even if it can be out of date. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Both ignores are not applicable anymore: - `gdbstub` moved from `paste` daniel5151/gdbstub#168 - `uuid` we have is `1.23.2` version Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6009 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 277 277
Lines 30201 30201
=======================================
Hits 25094 25094
Misses 5107 5107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace
crago-auditwithcrago-denyfor the advisory checks. This allows us to skip unnecessary notifications about crates we don't use, but which are pulled as dependencies from optional features of other crates.Also remove
.cargo/audit.tomlsince both ignores are not applicable anymore.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.