[BACKPORT 1.16] skip flaky hotplug tests on x86_64 5.10 hosts#6010
Merged
not4s merged 2 commits intoJun 30, 2026
Merged
Conversation
test_virtio_mem_hotplug_hotunplug and test_memory_hotplug_latency intermittently fail on x86_64 5.10 hosts, where the GET /hotplug/memory API call exceeds the maximum duration assertion. Skip both there until the latency is investigated. (cherry picked from commit ac7510c) Signed-off-by: Jay Chung <jaehoc@amazon.com> Signed-off-by: Jay Chung <jaehoc@amazon.com>
cargo-audit flags RUSTSEC-2026-0190, failing the security audit on all branches. anyhow is not a direct dependency of any Firecracker crate; it is only pulled in transitively by build-time WASM tooling (wit-bindgen), so we are not affected. Ignore it to unblock CI. (cherry picked from commit 573d249) Signed-off-by: Jay Chung <jaehoc@amazon.com> Signed-off-by: Jay Chung <jaehoc@amazon.com>
not4s
added
the
Status: Awaiting review
Manciukic
approved these changes
Jun 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.16 #6010 +/- ##
==================================================
Coverage 82.97% 82.97%
==================================================
Files 277 277
Lines 30092 30092
==================================================
Hits 24970 24970
Misses 5122 5122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JamesC1305
approved these changes
Jun 30, 2026
zulinx86
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Backport the two merged main commits to unblock v1.16.1 release QA (hotplug tests fail on x86_64 5.10; cargo-audit fails on RUSTSEC-2026-0190) #6007
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.