feat: add extractFormulasInRegions for native formula text extraction#40
Open
abimaelmartell wants to merge 1 commit intomainfrom
Open
feat: add extractFormulasInRegions for native formula text extraction#40abimaelmartell wants to merge 1 commit intomainfrom
abimaelmartell wants to merge 1 commit intomainfrom
Conversation
Add a new region extraction endpoint that uses formula-specific quality checks instead of the generic text garbage detector. Formula text is legitimately symbol-heavy (Greek letters, math operators, subscripts), so the standard is_garbage_text check — which requires >50% alphanumeric characters — would false-positive on valid formula regions. The new is_formula_garbage validator catches actual decode failures: PUA characters from undecoded TeX extensible delimiters (>10%) and control characters from broken font encodings (>30%). Also refactors the shared page-extraction boilerplate into prepare_region_extraction, eliminating duplication across extract_text_in_regions_mem and extract_tables_in_regions_mem. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractFormulasInRegionsNAPI export (andextract_formulas_in_regions_memRust API) for extracting text from formula bounding-box regions with formula-specific quality validationis_garbage_textcheck (requires >50% alphanumeric) would false-positive on valid formula regions. The new endpoint skips that check and instead usesis_formula_garbagewhich catches actual decode failures: PUA characters from undecoded TeX extensible delimiters (>10%) and control characters from broken font encodings (>30%)prepare_region_extraction, eliminating ~40 lines of duplication betweenextract_text_in_regions_memandextract_tables_in_regions_memTest plan
cargo fmt— cleancargo clippy -- -D warnings— zero warningscargo test— 104 passed (includes 5 newis_formula_garbageunit tests)🤖 Generated with Claude Code