Tidy up TrialFunction/LinearVariationalSolver support#227
Merged
Conversation
pbrubeck
force-pushed
the
pbrubeck/tidy-linear-solver
branch
3 times, most recently
from
446446a to
2d30f2e
Compare
pbrubeck
force-pushed
the
pbrubeck/tidy-linear-solver
branch
from
2d30f2e to
6c2f797
Compare
pbrubeck
commented
May 14, 2026
pbrubeck
force-pushed
the
pbrubeck/tidy-linear-solver
branch
2 times, most recently
from
fabfefc to
728c612
Compare
pbrubeck
force-pushed
the
pbrubeck/tidy-linear-solver
branch
from
728c612 to
5444235
Compare
Merged
jorgensd
reviewed
May 18, 2026
jorgensd
reviewed
May 18, 2026
jorgensd
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements upon #213
Avoids construction of an intermediate semi discrete linear form and goes straight from semi discrete bilinear form into the stage bilinear form.
Consistently use LVP/LVS across all time stepper classes.