fixup

Author: connorjward

.github/actions/install/action.yml

@@ -33,15 +33,14 @@ inputs:
 runs:
   using: composite
   steps:
-    - name: Pre-run cleanup
-      shell: bash
-      # Make sure the current directory is empty
-      run: find . -delete
-
     - name: Install system dependencies
       shell: bash
       run: |
         if [ ${{ inputs.os }} = 'linux' ]; then
+          : # Git is needed for actions/checkout and Python for firedrake-configure
+          apt-get update
+          apt-get -y install git python3
+
           apt-get -y install \
             $(python3 ./firedrake-repo/scripts/firedrake-configure --arch ${{ matrix.arch }} --show-system-packages)
           apt-get -y install python3-venv

.github/workflows/core.yml

@@ -107,22 +107,21 @@ jobs:
       EXTRA_PYTEST_ARGS: --splitting-algorithm least_duration --timeout=600 --timeout-method=thread -o faulthandler_timeout=660 --durations-path=./firedrake-repo/tests/test_durations.json --durations=50
       PYTEST_MPI_MAX_NPROCS: 8
     steps:
-      - uses: actions/checkout@v5
-        with:
-          path: firedrake-repo
-          ref: ${{ inputs.source_ref }}
-
+      # NOTE: is this needed any more?
       - name: Fix HOME
         # For unknown reasons GitHub actions overwrite HOME to /github/home
         # which will break everything unless fixed
         # (https://github.com/actions/runner/issues/863)
         run: echo "HOME=/root" >> "$GITHUB_ENV"
 
-      # Git is needed for actions/checkout and Python for firedrake-configure
-      - name: Install system dependencies (1)
-        run: |
-          apt-get update
-          apt-get -y install git python3
+      - name: Pre-run cleanup
+        # Make sure the current directory is empty
+        run: find . -delete
+
+      - uses: actions/checkout@v5
+        with:
+          path: firedrake-repo
+          ref: ${{ inputs.source_ref }}
 
       - name: Install Firedrake
         id: install
@@ -310,15 +309,19 @@ jobs:
       OMP_NUM_THREADS: 1
       OPENBLAS_NUM_THREADS: 1
     steps:
+      - name: Add homebrew to PATH
+        # https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-system-path
+        run: echo "/opt/homebrew/bin" >> "$GITHUB_PATH"
+
+      - name: Pre-run cleanup
+        # Make sure the current directory is empty
+        run: find . -delete
+
       - uses: actions/checkout@v5
         with:
           path: firedrake-repo
           ref: ${{ inputs.source_ref }}
 
-      - name: Add homebrew to PATH
-        # https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-system-path
-        run: echo "/opt/homebrew/bin" >> "$GITHUB_PATH"
-
       - name: Install Firedrake
         id: install
         uses: ./firedrake-repo/.github/actions/install