Improve building compiled extensions using Makefile (#5059)

* Improve building compiled extensions using Makefile

setuptools doesn't provide a way to clean up compiled extensions if they
are built inplace. make clean was therefore a best-guess, highly
bitrotted removal of the inplace extensions. It was removing many files
that no longer exist and failing to remove others.

Instead of this approach here we just provide a way to force a rebuild
of all extensions. The end result is the same but robust to future file
changes.

---------

Co-authored-by: Josh Hope-Collins <jhc.jss@gmail.com>

Author: connorjward

Makefile

@@ -1,10 +1,12 @@
-.PHONY: all
-all: modules
-
-.PHONY: modules
-modules:
+.PHONY: ext
+ext:
 	@echo "    Building extension modules"
-	@python setup.py build_ext --inplace > build.log 2>&1 || cat build.log
+	@python setup.py build_ext --inplace 2>&1 | tee cat build.log
+
+.PHONY: extforce
+extforce:
+	@echo "    Force building all extension modules"
+	@python setup.py build_ext --inplace --force 2>&1 | tee cat build.log
 
 .PHONY: lint
 lint: srclint actionlint dockerlint
@@ -55,39 +57,6 @@ dockerlint:
 			|| exit 1; \
 	done
 
-.PHONY: clean
-clean:
-	@echo "    Cleaning extension modules"
-	@python setup.py clean > /dev/null 2>&1
-	@echo "    RM firedrake/cython/dmplex.*.so"
-	-@rm -f firedrake/cython/dmplex.so > /dev/null 2>&1
-	@echo "    RM firedrake/cython/dmplex.c"
-	-@rm -f firedrake/cython/dmplex.c > /dev/null 2>&1
-	@echo "    RM firedrake/cython/extrusion_numbering.*.so"
-	-@rm -f firedrake/cython/extrusion_numbering.so > /dev/null 2>&1
-	@echo "    RM firedrake/cython/extrusion_numbering.c"
-	-@rm -f firedrake/cython/extrusion_numbering.c > /dev/null 2>&1
-	@echo "    RM firedrake/cython/hdf5interface.*.so"
-	-@rm -f firedrake/cython/hdf5interface.so > /dev/null 2>&1
-	@echo "    RM firedrake/cython/hdf5interface.c"
-	-@rm -f firedrake/cython/hdf5interface.c > /dev/null 2>&1
-	@echo "    RM firedrake/cython/spatialindex.*.so"
-	-@rm -f firedrake/cython/spatialindex.so > /dev/null 2>&1
-	@echo "    RM firedrake/cython/spatialindex.c"
-	-@rm -f firedrake/cython/spatialindex.c > /dev/null 2>&1
-	@echo "    RM firedrake/cython/supermeshimpl.*.so"
-	-@rm -f firedrake/cython/supermeshimpl.so > /dev/null 2>&1
-	@echo "    RM firedrake/cython/supermeshimpl.c"
-	-@rm -f firedrake/cython/supermeshimpl.c > /dev/null 2>&1
-	@echo "    RM firedrake/cython/mg/impl.*.so"
-	-@rm -f firedrake/cython/mg/impl.so > /dev/null 2>&1
-	@echo "    RM firedrake/cython/mg/impl.c"
-	-@rm -f firedrake/cython/mg/impl.c > /dev/null 2>&1
-	@echo "    RM pyop2/*.so"
-	-@rm -f pyop2/*.so > /dev/null 2>&1
-	@echo "    RM tinyasm/*.so"
-	-@rm -f tinyasm/*.so > /dev/null 2>&1
-
 # NOTE: It is recommended to run this command from inside the 'firedrake'
 # Docker image to reduce the likelihood of test failures.
 .PHONY: test_durations