Tighten tao tolerances in adjoint tests#5042
Closed
JHopeCollins wants to merge 1 commit intomainfrom
Closed
Conversation
connorjward
approved these changes
Apr 21, 2026
Contributor
|
Should this go into release? |
Member
Author
Yes, I'll move it over |
Member
Author
|
These changes will go into release in #5047 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the TAO optimisation tests started failing recently because it is now just missed the error tolerance on the optimised solution. Presumably something has changed in the solver stack so it is getting a slightly different solution.
Tightening up the tolerance makes the solution pass again. I looked at some of the other tests that use these parameter sets and some of them were also only just passing with the previous tolerance, so I don't think we mind the slight increase in the test durations.