Allow in place operators to modify coordinates#5214
Open
dham wants to merge 2 commits into
Open
Conversation
connorjward
previously approved these changes
Jul 7, 2026
Contributor
|
Should this go into release? |
leo-collins
reviewed
Jul 7, 2026
Contributor
There was a problem hiding this comment.
Could this go in firedrake/regression/test_change_coordinates.py instead of a new file?
dham
force-pushed
the
dham/inplace_coordinate_operators
branch
from
b268e8f to
8c24472
Compare
connorjward
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing the coordinates property of a mesh is not allowed for lots of good reasons.
However, the Python implementation of in place operators does assignment. That is to say:
is equivalent to:
This triggers the error even though
mesh.coordinates.__iadd__returnsmesh.coordinates. This PR relaxes the error check so that assigningmesh.coordinatesitself (i.e. a no-op) is allowed.